Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph] Graph hangs on PVC or with explicitly used Immediate Command List #10467

Closed
reble opened this issue Jul 19, 2023 · 2 comments
Closed

[SYCL][Graph] Graph hangs on PVC or with explicitly used Immediate Command List #10467

reble opened this issue Jul 19, 2023 · 2 comments
Assignees
@reble
Labels
bug Something isn't working sycl-graph

Comments

@reble
Copy link
Contributor

reble commented Jul 19, 2023 •
edited
Loading

Describe the bug
Using SYCL Graph extensions with either PVC HW or explicitly using Immediate Command List is not working as expected. App using both will hang and not terminate.

To Reproduce
Please describe the steps to reproduce the behavior:

  1. Code snippet to reproduce the issue can be found here: https://github.com/intel/llvm/blob/b1a5b473e1a48b96b00c8e158afa0f287efd4d72/sycl/test-e2e/Graph/RecordReplay/valid_no_end.cpp
  2. Compile with: clang++ -fsycl -fsycl-targets=spir64 sycl/test-e2e/Graph/RecordReplay/valid_no_end.cpp -o test
  3. Run with: SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 ./test
    Setting macro is optional on PVC hardware.
  4. Test should terminate and pass without exceptions.

Environment (please complete the following information):

  • OS: Linux
  • Target device and vendor: PVC or any Intel GPU (Explicit use of Immediate Command List)
  • DPC++ version: 72341ee
  • Dependencies version: none
@reble reble added the bug Something isn't working label Jul 19, 2023
@reble reble self-assigned this Jul 19, 2023
@EwanC EwanC mentioned this issue Aug 11, 2023
Merged
@reble
Copy link
Contributor Author

reble commented Aug 16, 2023 •
edited
Loading

Note: Queue property sycl::ext::intel::property::queue::no_immediate_command_list can be used instead of the environment variable.

https://github.com/intel/llvm/blob/99272476d096c0afbd1a9817abfa1a0a279b827d/sycl/doc/extensions/supported/sycl_ext_intel_queue_immediate_command_list.asciidoc

steffenlarsen pushed a commit that referenced this issue Aug 22, 2023
@EwanC
[SYCL][Graph] Throw an exception when unsupported features used in a …
8d8d3f4 
…graph (#10789)

This PR contains a set of changes that implement throwing an exception
when a feature unsupported by

[sycl_ext_oneapi_graph](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_graph.asciidoc)
is used.

An error is thrown when an application uses the following features with
the graph extension:
* An unsupported extension.
* Querying the event returned from graph submission for profiling
information.
* Level Zero immediate command-list (see
#10467)
* Specialization constants, kernel bundles, or reductions are used in a
graph node.

## Authors

Co-authored-by: Pablo Reble <pablo.reble@intel.com>
Co-authored-by: Julian Miller <julian.miller@intel.com>
Co-authored-by: Ben Tracy <ben.tracy@codeplay.com>
Co-authored-by: Ewan Crawford <ewan@codeplay.com>
Co-authored-by: Maxime France-Pillois
<maxime.francepillois@codeplay.com>
veselypeta pushed a commit to veselypeta/llvm that referenced this issue Sep 21, 2023
@EwanC
[SYCL][Graph] Throw an exception when unsupported features used in a …
fd179fa 
…graph (intel#10789)

This PR contains a set of changes that implement throwing an exception
when a feature unsupported by

[sycl_ext_oneapi_graph](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_graph.asciidoc)
is used.

An error is thrown when an application uses the following features with
the graph extension:
* An unsupported extension.
* Querying the event returned from graph submission for profiling
information.
* Level Zero immediate command-list (see
intel#10467)
* Specialization constants, kernel bundles, or reductions are used in a
graph node.

## Authors

Co-authored-by: Pablo Reble <pablo.reble@intel.com>
Co-authored-by: Julian Miller <julian.miller@intel.com>
Co-authored-by: Ben Tracy <ben.tracy@codeplay.com>
Co-authored-by: Ewan Crawford <ewan@codeplay.com>
Co-authored-by: Maxime France-Pillois
<maxime.francepillois@codeplay.com>
omarahmed1111 pushed a commit to omarahmed1111/unified-runtime that referenced this issue Oct 23, 2023
@EwanC @omarahmed1111
[SYCL][Graph] Throw an exception when unsupported features used in a …
89dbebd 
…graph (#10789)

This PR contains a set of changes that implement throwing an exception
when a feature unsupported by

[sycl_ext_oneapi_graph](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_graph.asciidoc)
is used.

An error is thrown when an application uses the following features with
the graph extension:
* An unsupported extension.
* Querying the event returned from graph submission for profiling
information.
* Level Zero immediate command-list (see
intel/llvm#10467)
* Specialization constants, kernel bundles, or reductions are used in a
graph node.

## Authors

Co-authored-by: Pablo Reble <pablo.reble@intel.com>
Co-authored-by: Julian Miller <julian.miller@intel.com>
Co-authored-by: Ben Tracy <ben.tracy@codeplay.com>
Co-authored-by: Ewan Crawford <ewan@codeplay.com>
Co-authored-by: Maxime France-Pillois
<maxime.francepillois@codeplay.com>
@mfrancepillois mfrancepillois mentioned this issue Dec 19, 2023
Closed
mfrancepillois added a commit to reble/llvm that referenced this issue Jan 3, 2024
@mfrancepillois
[SYCL][Graph] Enable Graphs with L0 immediate command-list
2a7cf1b 
Updates e2e tests to test L0 immediate command-lists.
Improves filecheck usage in graph E2E tests
Removes test that checks immediate command-list exception
Updates the spec.

Addresses Issue: intel#10467
@mfrancepillois mfrancepillois mentioned this issue Jan 3, 2024
Merged
sommerlukas pushed a commit that referenced this issue Feb 7, 2024
@mfrancepillois @Bensuo
[SYCL][Graph] Enable Graphs with L0 immediate command-list (#12279)
eead989 
Updates e2e tests to test L0 immediate command-lists. 
Improves filecheck usage in graph E2E tests
Removes test that checks immediate command-list exception. 
Updates the spec.

Addresses Issue: #10467

---------

Co-authored-by: Ben Tracy <ben.tracy@codeplay.com>
@EwanC
Copy link
Contributor

EwanC commented Apr 5, 2024

Closing as fixed by #12279

@EwanC EwanC closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reble reble

Labels
bug Something isn't working sycl-graph
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EwanC @reble