Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUDA][HIP] user_defined_reductions #12613

Closed
jinz2014 opened this issue Feb 5, 2024 · 2 comments · Fixed by #13057
Closed

[CUDA][HIP] user_defined_reductions #12613

jinz2014 opened this issue Feb 5, 2024 · 2 comments · Fixed by #13057
Labels
cuda CUDA back-end enhancement New feature or request hip Issues related to execution on HIP backend.

Comments

@jinz2014
Copy link
Contributor

jinz2014 commented Feb 5, 2024

// UNSUPPORTED: cuda || hip

#include <sycl/ext/oneapi/experimental/user_defined_reductions.hpp>

File: test-e2e/UserDefinedReductions/user_defined_reductions.cpp
@jinz2014 jinz2014 added the enhancement New feature or request label Feb 5, 2024
@AlexeySachkov AlexeySachkov added cuda CUDA back-end hip Issues related to execution on HIP backend. labels Feb 6, 2024
@jinz2014
Copy link
Contributor Author

jinz2014 commented Feb 6, 2024

I think the line '// UNSUPPORTED: cuda || hip' could be removed in the file. Thanks for checking again.

@MaryaSharf MaryaSharf mentioned this issue Mar 18, 2024
Merged
@steffenlarsen
Copy link
Contributor

Patch to re-enable the test here: #13057

ldrumm pushed a commit that referenced this issue Mar 19, 2024
@MaryaSharf
[CUDA][HIP] Enable user_defined_reductions for cuda and hip. (#13057)
9431225 
This patch enables user_defined_reductions.cpp for cuda and hip.
It's been verified that the test is now supported for cuda and hip now,
this closes #12613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cuda CUDA back-end enhancement New feature or request hip Issues related to execution on HIP backend.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CUDA][HIP] Enable user_defined_reductions for cuda and hip. MaryaSharf/llvm
3 participants
@AlexeySachkov @jinz2014 @steffenlarsen