Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph/Explicit/host_task_single fails in Windows pre-commit CI for unrelated changes #13862

Closed
steffenlarsen opened this issue May 21, 2024 · 2 comments
Labels
bug Something isn't working confirmed sycl-graph

Comments

@steffenlarsen
Copy link
Contributor

Describe the bug

Graph/Explicit/host_task_single failed on #13801 though the PR only touches unrelated unit-tests. Failure:

# .---command stderr------------
# | command line:1:22: error: IMPLICIT-CHECK-NOT: excluded string found in input
# | -implicit-check-not='LEAK'
# |                      ^
# | <stdin>:3:54: note: found here
# |  zeContextCreate = 1 \---> zeContextDestroy = 0 ---> LEAK = 1
# |                                                      ^~~~
# | 
# | Input file: <stdin>
# | Check file: D:\github\actions-runner\_work\llvm\llvm\llvm\sycl\test-e2e\Graph\Explicit\host_task_single.cpp
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |           1: Check balance of create/destroy calls 
# |           2: ---------------------------------------------------------- 
# |           3:  zeContextCreate = 1 \---> zeContextDestroy = 0 ---> LEAK = 1 
# | not:imp1                                                          !~~~      error: no match expected
# |           4:  zeCommandQueueCreate = 0 \---> zeCommandQueueDestroy = 0  
# |           5:  zeModuleCreate = 0 \---> zeModuleDestroy = 0  
# |           6:  zeKernelCreate = 0 \---> zeKernelDestroy = 0  
# |           7:  zeEventPoolCreate = 1 \---> zeEventPoolDestroy = 0 ---> LEAK = 1 
# |           8:  zeCommandListCreateImmediate = 2 |  
# |           .
# |           .
# |           .
# | >>>>>>
# `-----------------------------

To reproduce

No response

Environment

No response

Additional context

No response

@EwanC
Copy link
Contributor

EwanC commented May 21, 2024

Thanks for reporting, looks like we need to extend the fix in #13802 because for some reason it didn't skip this despite https://github.com/intel/llvm/actions/runs/9108501375/job/25040698422?pr=13801 being a Windows L0 run with immediate command-lists

EwanC added a commit to reble/llvm that referenced this issue May 21, 2024
PR intel#13802 disabled the L0 leak checking
in `host_task_single.cpp` for immediate command-lists on Windows.

However issue intel#13862 has highlighted
that this needs extended to also disabling the linux case due to CI fail
https://github.com/intel/llvm/actions/runs/9108501375/job/25040698422?pr=13801

```
```
@EwanC
Copy link
Contributor

EwanC commented May 21, 2024

Actually it looks like the CI run in https://github.com/intel/llvm/actions/runs/9108501375/job/25040698422?pr=13801 ran 5 days ago on May 16th at 10:10AM, and #13802 was merged on May 16th at 15:41

So I think the PR testing in #13801 was a bit too early for the disabled test.

@EwanC EwanC closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed sycl-graph
Projects
None yet
Development

No branches or pull requests

2 participants