[SYCL][UR] Upgrade UR to 2023-09-15 release #11281
Conversation
0x12CC
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
0x12CC
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| @@ -31,8 +31,6 @@ UR_DLLEXPORT ur_result_t UR_APICALL urGetGlobalProcAddrTable( | |||
| return retVal; | |||
| } | |||
|
|
|||
| pDdiTable->pfnInit = urInit; | |||
There was a problem hiding this comment.
we dont need anymore urInit and urTearDown? here we are removing it from all the tables, so are we removing them from the spec?
There was a problem hiding this comment.
I believe they've already been removed from the specification. The following PR changed them to urLoaderInit and urLoaderTearDown: oneapi-src/unified-runtime#793.
@callumfare, could you please review these changes?
There was a problem hiding this comment.
These changes look correct to me, urInit and urTearDown are now loader-only so should no longer be implemented by the individual adapters.
That said our last attempt to bump the UR commit was reverted in #11227 so I'm not sure if we can bump it again until it's clear whatever issues were occurring are resolved.
There was a problem hiding this comment.
Thanks, @callumfare! I wasn't aware of #11227 but this PR should include those changes as I'm upgrading to a newer release.
@aelovikov-intel, have these CI issues since been resolved? This PR blocks a lot of other work since it's not possible to add new PI APIs without upgrading UR.
There was a problem hiding this comment.
@aelovikov-intel, have these CI issues since been resolved? This PR blocks a lot of other work since it's not possible to add new PI APIs without upgrading UR.
No. Every time I'm watching the PRs created in my timezone everything goes smoothly. Then overnight/weekend I see our runners in a bad state. I'll repeat - please do NOT create/update any changes for the UR update until we get at least two days with everything green in CI.
There was a problem hiding this comment.
I believe the issues have been resolved with #11306. Please merge latest origin/sycl for re-test.
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
0x12CC
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
0x12CC
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Michael Aziz <michael.aziz@intel.com>
0x12CC
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
This PR isn't needed anymore since there's a new process for updating UR with each adapter change. |
Where is that described? I'd like to understand how that can affect our CI. |
I'm referring to this process: https://github.com/oneapi-src/unified-runtime/pull/902/files. It seems like each PR that makes an adapter change will update the UR commit used in SYCL. |
No description provided.