From 0e5a2997130677b22a169bab036b221b12085dc9 Mon Sep 17 00:00:00 2001 From: Sergey Semenov Date: Tue, 30 Jan 2024 08:12:50 -0800 Subject: [PATCH] [SYCL]{NFC] Remove duplicate checks from InOrderQueueSyncCheck --- .../scheduler/InOrderQueueSyncCheck.cpp | 33 ++----------------- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/sycl/unittests/scheduler/InOrderQueueSyncCheck.cpp b/sycl/unittests/scheduler/InOrderQueueSyncCheck.cpp index f88dea4b398f9..a07271bf88a44 100644 --- a/sycl/unittests/scheduler/InOrderQueueSyncCheck.cpp +++ b/sycl/unittests/scheduler/InOrderQueueSyncCheck.cpp @@ -56,43 +56,14 @@ TEST_F(SchedulerTest, InOrderQueueSyncCheck) { sycl::detail::getSyclObjImpl(Dev), sycl::async_handler{}, sycl::property::queue::in_order()); - // What we are testing here: - // Task type | Must depend on - // host | yes - always, separate sync management - // host | yes - always, separate sync management - // kernel | yes - change of sync approach - // kernel | yes - sync between pi calls must be done by backend, but we - // still add dependency to handle the right order due to host task. This - // dependency will not be sent to backend. It is checked in - // SchedulerTest.InOrderQueueCrossDeps - // host | yes - always, separate sync management - + // Check that tasks submitted to an in-order queue implicitly depend_on the + // previous task, this is needed to properly sync blocking & blocked tasks. sycl::event Event; - // host task { LimitedHandlerSimulation MockCGH; EXPECT_CALL(MockCGH, depends_on).Times(0); Queue->finalizeHandler(MockCGH, Event); } - // host task - { - LimitedHandlerSimulation MockCGH; - EXPECT_CALL(MockCGH, depends_on).Times(1); - Queue->finalizeHandler(MockCGH, Event); - } - // kernel task - { - LimitedHandlerSimulation MockCGH; - EXPECT_CALL(MockCGH, depends_on).Times(1); - Queue->finalizeHandler(MockCGH, Event); - } - // kernel task - { - LimitedHandlerSimulation MockCGH; - EXPECT_CALL(MockCGH, depends_on).Times(1); - Queue->finalizeHandler(MockCGH, Event); - } - // host task { LimitedHandlerSimulation MockCGH; EXPECT_CALL(MockCGH, depends_on).Times(1);