Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL]{NFC] Remove duplicate checks from InOrderQueueSyncCheck #12546

Merged
merged 2 commits into from
Feb 2, 2024
Merged

[SYCL]{NFC] Remove duplicate checks from InOrderQueueSyncCheck #12546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e5a299
[SYCL]{NFC] Remove duplicate checks from InOrderQueueSyncCheck
sergey-semenov Jan 30, 2024
8b0ca55
Merge branch 'sycl' into simplifyinorderqtest
sergey-semenov Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 2 additions & 31 deletions sycl/unittests/scheduler/InOrderQueueSyncCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,43 +56,14 @@ TEST_F(SchedulerTest, InOrderQueueSyncCheck) {
sycl::detail::getSyclObjImpl(Dev), sycl::async_handler{},
sycl::property::queue::in_order());

// What we are testing here:
// Task type | Must depend on
// host | yes - always, separate sync management
// host | yes - always, separate sync management
// kernel | yes - change of sync approach
// kernel | yes - sync between pi calls must be done by backend, but we
// still add dependency to handle the right order due to host task. This
// dependency will not be sent to backend. It is checked in
// SchedulerTest.InOrderQueueCrossDeps
// host | yes - always, separate sync management

// Check that tasks submitted to an in-order queue implicitly depend_on the
// previous task, this is needed to properly sync blocking & blocked tasks.
sycl::event Event;
// host task
{
LimitedHandlerSimulation MockCGH;
EXPECT_CALL(MockCGH, depends_on).Times(0);
Queue->finalizeHandler<LimitedHandlerSimulation>(MockCGH, Event);
}
// host task
{
LimitedHandlerSimulation MockCGH;
EXPECT_CALL(MockCGH, depends_on).Times(1);
Queue->finalizeHandler<LimitedHandlerSimulation>(MockCGH, Event);
}
// kernel task
{
LimitedHandlerSimulation MockCGH;
EXPECT_CALL(MockCGH, depends_on).Times(1);
Queue->finalizeHandler<LimitedHandlerSimulation>(MockCGH, Event);
}
// kernel task
{
LimitedHandlerSimulation MockCGH;
EXPECT_CALL(MockCGH, depends_on).Times(1);
Queue->finalizeHandler<LimitedHandlerSimulation>(MockCGH, Event);
}
// host task
{
LimitedHandlerSimulation MockCGH;
EXPECT_CALL(MockCGH, depends_on).Times(1);
Expand Down
Loading