[SYCL] Replace acc with 'fpga' in tests using ONEAPI_DEVICE_SELECTOR
#12551
Conversation
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sycl/test-e2e/Sampler/basic-rw.cpp
Outdated
| @@ -15,7 +15,7 @@ | |||
| ONEAPI_DEVICE_SELECTOR=level_zero:gpu ./binx.bin | |||
| ONEAPI_DEVICE_SELECTOR=opencl:cpu ./binx.bin | |||
|
|
|||
| ONEAPI_DEVICE_SELECTOR=opecl:acc ../binx.bin <-- does not support image | |||
| ONEAPI_DEVICE_SELECTOR=opencl:fpga ../binx.bin <-- does not support image | |||
There was a problem hiding this comment.
accelerator is what our OpenCL plugin reports and also what we document in the oneapi-construction-kit i how to use with dpc++ - are you saying that "fpga" will map onto this?
There was a problem hiding this comment.
As per the ONEAPI_DEVICE_SELECTOR documentation, the device type can only be cpu, gpu, or fpga (or any combination of those). Currently, 'acc' is also accepted by ONEAPI_DEVICE_SELECTOR as a valid device type, which is incorrect.
Therefore, I'm changing test cases and documentation, that uses ONEAPI_DEVICE_SELECTOR with 'acc' device type to instead use 'fpga'. Functionality wise, 'acc' and 'fpga' device types are equivalent so this change should not change the functionality of the test cases.
There was a problem hiding this comment.
I don't know about the test cases, I just wanted to be sure we can put fpga when the opencl device says accelerator.
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
changed the title
acc from device type in ONEAPI_DEVICE_SELECTORacc from device type in ONEAPI_DEVICE_SELECTOR
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Will do it in a seperate PR
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
changed the title
acc from device type in ONEAPI_DEVICE_SELECTORacc with 'fpga' in tests using ONEAPI_DEVICE_SELECTOR
|
@aelovikov-intel I have modified this PR to only make changes in the existing tests. I will make another PR to drop 'acc' support. |
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers the PR is ready. |
…ion using ONEAPI_DEVICE_SELECTOR
) As per the ONEAPI_DEVICE_SELECTOR [documentation](https://github.com/intel/llvm/blob/sycl/sycl/doc/EnvironmentVariables.md#oneapi_device_selector), the device type can only be cpu, gpu, or fpga (or any combination of those). Currently, 'acc' is also accepted by ONEAPI_DEVICE_SELECTOR as a valid device type, which is incorrect. This PR modifies drops support of 'acc' in ONEAPI_DEVICE_SELECTOR in favor of 'fpga'. We have already updated existing test cases (#12551), testing scripts (#12596 ) to use 'fpga' with ONEAPI_DEVICE_SELECTOR.
As per the ONEAPI_DEVICE_SELECTOR documentation, the device type can only be cpu, gpu, or fpga (or any combination of those). Currently, 'acc' is also accepted by ONEAPI_DEVICE_SELECTOR as a valid device type, which is incorrect.
This PR modifies existing test cases to use 'fpga' instead of 'acc' in ONEAPI_DEVICE_SELECTOR.
In future, we will completely drop 'acc' from device type in ONEAPI_DEVICE_SELECTOR.
Partially addresses: #12387