Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][ESIMD] Fix a few issues with scatter(usm, ...) #12585

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Feb 1, 2024

Problems found by Gregory (thanks!):

  1. There were some duplicated tests, remove those

  2. We didn't test non-LSC mask on Gen12

  3. We get an ambiguous call because we had an old function that didn't have VS, but the new functions have default VS=1, so we don't need the old one.

  4. When we pass a simd_view for the vals, we got a template match failure. This is the same issue we hit in the compile-time tests where even if we have a simd_view overload the compiler can't infer N, so we need to provide T,N anyway, so add that in the tests.

I tested this on Gen12.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex marked this pull request as ready for review February 1, 2024 19:21
@sarnex sarnex requested a review from a team as a code owner February 1, 2024 19:21
@sarnex sarnex merged commit 8bfc56f into intel:sycl Feb 1, 2024
12 checks passed
@aelovikov-intel
Copy link
Contributor

SYCL Nightly failures on OCL CPU (AMD runner):

Timed Out Tests (1):
  SYCL :: GroupAlgorithm/root_group.cpp
TIMEOUT: SYCL :: GroupAlgorithm/root_group.cpp (1858 of 1858)
******************** TEST 'SYCL :: GroupAlgorithm/root_group.cpp' FAILED ********************
Exit Code: -9
Timeout: Reached timeout of 600 seconds

Command Output (stdout):
--
# RUN: at line 1
/__w/llvm/llvm/toolchain/bin//clang++   -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/GroupAlgorithm/root_group.cpp -I . -o /__w/llvm/llvm/build-e2e/GroupAlgorithm/Output/root_group.cpp.tmp.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/GroupAlgorithm/root_group.cpp -I . -o /__w/llvm/llvm/build-e2e/GroupAlgorithm/Output/root_group.cpp.tmp.out
# note: command had no output on stdout or stderr
# RUN: at line 2
env ONEAPI_DEVICE_SELECTOR=opencl:cpu  /__w/llvm/llvm/build-e2e/GroupAlgorithm/Output/root_group.cpp.tmp.out
# executed command: env ONEAPI_DEVICE_SELECTOR=opencl:cpu /__w/llvm/llvm/build-e2e/GroupAlgorithm/Output/root_group.cpp.tmp.out
# note: command had no output on stdout or stderr
# error: command failed with exit status: -9
# error: command reached timeout: True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants