From b549e473dc8237fe97c174236e621bc2a56438b5 Mon Sep 17 00:00:00 2001 From: Lukas Sommer Date: Tue, 6 Feb 2024 13:08:28 +0000 Subject: [PATCH] [SYCL][Fusion][NFC] Remove name and ticket ID from TODOs --- sycl/source/detail/jit_compiler.cpp | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/sycl/source/detail/jit_compiler.cpp b/sycl/source/detail/jit_compiler.cpp index 7a452115f5a94..a47b0755631d6 100644 --- a/sycl/source/detail/jit_compiler.cpp +++ b/sycl/source/detail/jit_compiler.cpp @@ -667,8 +667,8 @@ jit_compiler::fuseKernels(QueueImplPtr Queue, unsigned KernelIndex = 0; ParamList FusedParams; PromotionMap PromotedAccs; - // TODO(Lukas, ONNX-399): Collect information about streams and auxiliary - // resources (which contain reductions) and figure out how to fuse them. + // TODO: Collect information about streams and auxiliary resources (which + // contain reductions) and figure out how to fuse them. for (auto &RawCmd : InputKernels) { auto *KernelCmd = static_cast(RawCmd); auto &CG = KernelCmd->getCG(); @@ -760,8 +760,7 @@ jit_compiler::fuseKernels(QueueImplPtr Queue, } } - // TODO(Lukas, ONNX-399): Check for the correct kernel bundle state of the - // device image? + // TODO: Check for the correct kernel bundle state of the device image? auto &RawDeviceImage = DeviceImage->getRawData(); auto DeviceImageSize = static_cast(RawDeviceImage.BinaryEnd - RawDeviceImage.BinaryStart); @@ -803,8 +802,7 @@ jit_compiler::fuseKernels(QueueImplPtr Queue, // Not all overloads of parallel_for_work_group only specify the number of // work-groups, so the above mechanism might not detect all hierarchical // parallelism. - // TODO(Lukas, CRD-6): Find a more reliable way to detect hierarchical - // parallelism. + // TODO: Find a more reliable way to detect hierarchical parallelism. } // We need to copy the storages here. The input CGs might be eliminated @@ -815,9 +813,9 @@ jit_compiler::fuseKernels(QueueImplPtr Queue, KernelCG->getArgsStorage().end()); AccStorage.insert(AccStorage.end(), KernelCG->getAccStorage().begin(), KernelCG->getAccStorage().end()); - // TODO(Lukas, ONNX-399): Does the MSharedPtrStorage contain any - // information about actual shared pointers beside the kernel bundle and - // handler impl? If yes, we might need to copy it here. + // TODO: Does the MSharedPtrStorage contain any information about actual + // shared pointers beside the kernel bundle and handler impl? If yes, we + // might need to copy it here. Requirements.insert(Requirements.end(), KernelCG->getRequirements().begin(), KernelCG->getRequirements().end()); Events.insert(Events.end(), KernelCG->getEvents().begin(),