[SYCL][Joint Matrix Tests] Add fill/store/apply tests for 16x16x16, 32x64x16 #12629
Conversation
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
force-pushed
the
add_big_comp_fill_store_test
branch
from
515eb0d
to
fadd8af
Compare
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
force-pushed
the
add_big_comp_fill_store_test
branch
from
fadd8af
to
61c5b46
Compare
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
force-pushed
the
add_big_comp_fill_store_test
branch
from
61c5b46
to
3069fc9
Compare
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
force-pushed
the
add_big_comp_fill_store_test
branch
2 times, most recently
from
21297f1
to
ba6703b
Compare
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
force-pushed
the
add_big_comp_fill_store_test
branch
from
ba6703b
to
d6d6278
Compare
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
changed the title
YuriPlyakhin
changed the title
YuriPlyakhin
force-pushed
the
add_big_comp_fill_store_test
branch
from
d6d6278
to
64fd280
Compare
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
YuriPlyakhin
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -122,7 +122,8 @@ int main() { | |||
| float>(); | |||
| } | |||
| } | |||
| if (combinations[i].atype == matrix_type::sint8) { | |||
| if (combinations[i].atype == matrix_type::sint8 && | |||
There was a problem hiding this comment.
I noticed 2 combinations satisfy this condition, so the same tests are running 2 times on PVC, hence added one more condition, so only 1 combination satisfies the condition.
YuriPlyakhin
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| void matrix_multiply_ref(Ta *A, Tb *B, Tc *C, int M, int N, int K, | ||
| bool transpose_c = false, bool colmajor_a = false, | ||
| bool colmajor_b = false) { | ||
| bool colmajor_b = false, F &&lambda = {}) { |
There was a problem hiding this comment.
This function got very complicated instead of just adding a new one like I suggested: matrix_multiply_apply_ref as these are two different things.
To avoid code duplication, matrix_multiply_apply_ref would call matrix_multiply_ref
There was a problem hiding this comment.
If matrix_multiply_apply_ref would call matrix_mulitply_ref, then multiplication and apply would not be fused, right? Then what is the point of adding matrix_multiply_apply_ref? Why not just use matrix_multiply_ref and then matrix_apply_ref, as I initially did?
There was a problem hiding this comment.
I thought you did not want to fuse. In this case the point is to use modularity.
A new function with fusion would be perfect. We could outline the duplicated code in an another function.
There was a problem hiding this comment.
Well, I did not want to create a new fused version, as I thought that would be too much just for one test case. But then I figured I can make a fused version out of the existing multiply function with just a few simple changes. So I decided to produce a fused version without creating more entities. Yes, function naming is not ideal now, but overall, I don't consider it to be very complicated and it allows both multiplication and apply in a fused way, while if test requires only multiplication, call can be kept simple, as apply-related parameters are optional.
|
@intel/llvm-gatekeepers , please, merge. all green. |
No description provided.