[UR] Pass pi_mem_properties in pi2ur for piMemBufferCreate #12665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Feb 8, 2024
nrspruit
commented
- Remove the restriction in pi2ur such that piMemBufferCreate can pass the pi_mem_properties as the pNext properties to the UR Adapters.
nrspruit
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
nrspruit
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/unified-runtime-reviewers , please let me know if you see any issues with this change that could impact the adapters. This re-enables the usage of the pi mem properties used in the opencl adapter at least. |
aarongreig
reviewed
Feb 9, 2024
| UR_STRUCTURE_TYPE_BUFFER_ALLOC_LOCATION_PROPERTIES; | ||
| if (properties != nullptr) { | ||
| constexpr uint64_t defaultBufferLocation = 7777; | ||
| constexpr uint32_t defaultBufferMemChannel = 7777; |
There was a problem hiding this comment.
I understand that this is astronomically unlikely to cause a problem by being a legit value for these properties one day, but I still think it's asking for trouble. I'd rather these two were boolean flags that get set if we find the corresponding property
There was a problem hiding this comment.
Thanks @aarongreig ,
I have updated accordingly.
- Remove the restriction in pi2ur such that piMemBufferCreate can pass the pi_mem_properties as the pNext properties to the UR Adapters. Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
pi2ur_piMemBufferProperties
branch
from
ed96c4e
to
0b739a1
Compare
nrspruit
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
approved these changes
Feb 9, 2024
nrspruit
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Test failure for gen12 is an env issue: .---command stdout------------| Abort was called at 253 line in file:| ../../neo/level_zero/core/source/builtin/builtin_functions_lib_impl.cpp`-----------------------------that failure is in the level zero gpu driver and does not have anything to do with the changes in this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.