Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UR] Pass pi_mem_properties in pi2ur for piMemBufferCreate #12665

Merged
merged 1 commit into from
Feb 9, 2024
Merged

[UR] Pass pi_mem_properties in pi2ur for piMemBufferCreate #12665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 38 additions & 4 deletions sycl/plugins/unified_runtime/pi2ur.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2670,10 +2670,6 @@ inline pi_result piMemBufferCreate(pi_context Context, pi_mem_flags Flags,
PI_ASSERT(Context, PI_ERROR_INVALID_CONTEXT);
PI_ASSERT(RetMem, PI_ERROR_INVALID_VALUE);

if (properties != nullptr) {
die("piMemBufferCreate: no mem properties goes to Level-Zero RT yet");
}

ur_context_handle_t UrContext =
reinterpret_cast<ur_context_handle_t>(Context);

Expand All @@ -2697,6 +2693,44 @@ inline pi_result piMemBufferCreate(pi_context Context, pi_mem_flags Flags,
ur_buffer_properties_t UrProps{};
UrProps.stype = UR_STRUCTURE_TYPE_BUFFER_PROPERTIES;
UrProps.pHost = HostPtr;

ur_buffer_channel_properties_t bufferChannelProperties{};
bufferChannelProperties.stype = UR_STRUCTURE_TYPE_BUFFER_CHANNEL_PROPERTIES;
ur_buffer_alloc_location_properties_t bufferLocationProperties{};
bufferLocationProperties.stype =
UR_STRUCTURE_TYPE_BUFFER_ALLOC_LOCATION_PROPERTIES;
if (properties != nullptr) {
bool bufferLocationPropertySet = false;
bool bufferMemChannelPropertySet = false;
uint64_t allocBufferLocation = 0;
uint32_t allocBufferMemChannel = 0;
// pi mem properties must ended by 0
size_t I = 0;
while (properties[I] != 0) {
if (properties[I] == PI_MEM_PROPERTIES_ALLOC_BUFFER_LOCATION) {
allocBufferLocation = properties[I + 1];
bufferLocationPropertySet = true;
} else if (properties[I] == PI_MEM_PROPERTIES_CHANNEL) {
allocBufferMemChannel = properties[I + 1];
bufferMemChannelPropertySet = true;
}
I += 2;
}
void *extensionProperties = nullptr;
if (bufferLocationPropertySet) {
bufferLocationProperties.location = allocBufferLocation;
extensionProperties = &bufferLocationProperties;
}
if (bufferMemChannelPropertySet) {
bufferChannelProperties.channel = allocBufferMemChannel;
extensionProperties = &bufferChannelProperties;
}
if (bufferLocationPropertySet && bufferMemChannelPropertySet) {
bufferLocationProperties.pNext = &bufferChannelProperties;
extensionProperties = &bufferLocationProperties;
}
UrProps.pNext = extensionProperties;
}
ur_mem_handle_t *UrBuffer = reinterpret_cast<ur_mem_handle_t *>(RetMem);
HANDLE_ERRORS(
urMemBufferCreate(UrContext, UrBufferFlags, Size, &UrProps, UrBuffer));
Expand Down
Loading