From 0cff726d0f7b3c0af748fcc447b0b3cd705932cc Mon Sep 17 00:00:00 2001 From: Victor Perez Date: Fri, 9 Feb 2024 13:40:32 +0000 Subject: [PATCH 1/2] [SYCL][Fusion][NFC] Comment fusion abortion on inter-fusion dependency Add comment stating event dependencies on any commands part of a different active fusion leads to the abortion of that fusion. Signed-off-by: Victor Perez --- sycl/source/detail/scheduler/graph_builder.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sycl/source/detail/scheduler/graph_builder.cpp b/sycl/source/detail/scheduler/graph_builder.cpp index 5a26623ce4003..8b8db752a8346 100644 --- a/sycl/source/detail/scheduler/graph_builder.cpp +++ b/sycl/source/detail/scheduler/graph_builder.cpp @@ -967,7 +967,7 @@ Scheduler::GraphBuildResult Scheduler::GraphBuilder::addCG( continue; } // Handle event dependencies on any commands part of another active - // fusion. + // fusion by aborting it. if (EvDepCmd->getQueue() != Queue && isPartOfActiveFusion(EvDepCmd)) { printFusionWarning( "Aborting fusion because of event dependency from a " From d4ad2c5100f597180f7f5f924ad3ad9aefc923a3 Mon Sep 17 00:00:00 2001 From: Victor Perez Date: Mon, 12 Feb 2024 09:55:12 +0000 Subject: [PATCH 2/2] Be more explicit --- sycl/source/detail/scheduler/graph_builder.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sycl/source/detail/scheduler/graph_builder.cpp b/sycl/source/detail/scheduler/graph_builder.cpp index 8b8db752a8346..e9ed3f2bb6e4b 100644 --- a/sycl/source/detail/scheduler/graph_builder.cpp +++ b/sycl/source/detail/scheduler/graph_builder.cpp @@ -966,8 +966,8 @@ Scheduler::GraphBuildResult Scheduler::GraphBuilder::addCG( ++Ev; continue; } - // Handle event dependencies on any commands part of another active - // fusion by aborting it. + // Event dependencies on commands part of another active fusion are + // handled by cancelling fusion in that other queue. if (EvDepCmd->getQueue() != Queue && isPartOfActiveFusion(EvDepCmd)) { printFusionWarning( "Aborting fusion because of event dependency from a "