Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFCI][SYCL] Support multi_ptr in convertToOpenCLType #12693

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Feb 12, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

using DecoratedPtrTy = decltype(DecoratedPtr);
using ElemTy = remove_decoration_t<std::remove_pointer_t<DecoratedPtrTy>>;

using TargetElemTy = SelectBlockT<ElemTy>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ElemTy has cv qualifier, it looks like SelectBlockT is going to drop that qualifier.
Maybe my understanding is wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but I don't think it's a regression caused by this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
NIT: In that case it will be nice to have some todo maybe, otherwise I guess it will be forgotten.

@againull againull self-requested a review February 13, 2024 20:05
using DecoratedPtrTy = decltype(DecoratedPtr);
using ElemTy = remove_decoration_t<std::remove_pointer_t<DecoratedPtrTy>>;

using TargetElemTy = SelectBlockT<ElemTy>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
NIT: In that case it will be nice to have some todo maybe, otherwise I guess it will be forgotten.

@aelovikov-intel
Copy link
Contributor Author

Pre-commit CI failure on Win:

Failed Tests (1):
  SYCL :: Graph/RecordReplay/barrier_with_work.cpp
FAIL: SYCL :: Graph/RecordReplay/barrier_with_work.cpp (951 of 1890)
******************** TEST 'SYCL :: Graph/RecordReplay/barrier_with_work.cpp' FAILED ********************
Exit Code: 3221226505

Command Output (stdout):
--
# RUN: at line 1
D:/github/_work/llvm/llvm/install/bin/clang++.exe   -fsycl -fsycl-targets=spir[64](https://github.com/intel/llvm/actions/runs/7892499647/job/21541937410#step:12:65) D:\github\_work\llvm\llvm\llvm\sycl\test-e2e\Graph\RecordReplay\barrier_with_work.cpp -o D:\github\_work\llvm\llvm\build-e2e\Graph\RecordReplay\Output\barrier_with_work.cpp.tmp.out
# executed command: D:/github/_work/llvm/llvm/install/bin/clang++.exe -fsycl -fsycl-targets=spir64 'D:\github\_work\llvm\llvm\llvm\sycl\test-e2e\Graph\RecordReplay\barrier_with_work.cpp' -o 'D:\github\_work\llvm\llvm\build-e2e\Graph\RecordReplay\Output\barrier_with_work.cpp.tmp.out'
# note: command had no output on stdout or stderr
# RUN: at line 2
env ONEAPI_DEVICE_SELECTOR=level_zero:gpu  D:\github\_work\llvm\llvm\build-e2e\Graph\RecordReplay\Output\barrier_with_work.cpp.tmp.out
# executed command: env ONEAPI_DEVICE_SELECTOR=level_zero:gpu 'D:\github\_work\llvm\llvm\build-e2e\Graph\RecordReplay\Output\barrier_with_work.cpp.tmp.out'
# .---command stdout------------
# | Unexpected value at index [71](https://github.com/intel/llvm/actions/runs/7892499647/job/21541937410#step:12:72)2 for DataA: 713 (got) vs 718 (expected)
# `-----------------------------
# .---command stderr------------
# | Assertion failed: check_value(i, ReferenceA[i], DataA[i], "DataA"), file D:/github/_work/llvm/llvm/llvm/sycl/test-e2e/Graph/RecordReplay/barrier_with_work.cpp, line 118
# `-----------------------------
# error: command failed with exit status: 0xc0000409

Github search (https://github.com/search?q=repo%3Aintel%2Fllvm+Graph%2FRecordReplay%2Fbarrier_with_work.cpp&type=pullrequests) didn't find anything but it doesn't look like it's related to this PR either. Tagging @intel/sycl-graphs-reviewers for awareness.

I believe it's very unlikely this has been caused by this PR so I'm going to merge it and monitor post-commit afterwards. If it fails, I'll revert. I don't think it would be beneficial to just restart pre-commit and increase the load on CI.

@aelovikov-intel aelovikov-intel merged commit e5da67b into intel:sycl Feb 13, 2024
10 of 11 checks passed
@aelovikov-intel aelovikov-intel deleted the convert-multi-ptr branch February 13, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants