[SYCL] Fix failing specialization constants tests. #12839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes made to specialization constants tests relied on --debug-only option, which is only enabled when assertions are enabled. This commit guards the commands using such an option to be run only when assertions are enabled. Signed-off-by: Marcos Maronas <marcos.maronas@intel.com>
bader
reviewed
Feb 27, 2024
llvm/test/tools/sycl-post-link/spec-constants/SYCL-2020-zeroinitializer-array-of-arrays.ll
Outdated
Show resolved
Hide resolved
| @@ -1,6 +1,6 @@ | |||
| ; RUN: sycl-post-link -spec-const=emulation < %s -o %t.files.table | |||
| ; RUN: FileCheck %s -input-file=%t.files_0.prop | |||
| ; RUN: sycl-post-link -debug-only=SpecConst -spec-const=emulation < %s 2>&1 | FileCheck %s --check-prefix=CHECK-LOG | |||
| ; RUN: %if asserts %{ sycl-post-link -debug-only=SpecConst -spec-const=emulation < %s 2>&1 | FileCheck %s --check-prefix=CHECK-LOG %} %else %{ %} | |||
There was a problem hiding this comment.
Empty else isn't necessary.
|
Should be up to the @intel/dpcpp-tools-reviewers if they're ok with reduced coverage (not performing checks in release builds in testing). |
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Actually, what was added in #12647 was extra coverage that required |
Signed-off-by: Marcos Maronas <marcos.maronas@intel.com>
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Feb 27, 2024
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes made to specialization constants tests relied on
--debug-onlyoption, which is only enabled when assertions are enabled. This commit guards the commands using such an option to be run only when assertions are enabled.This should fix the post-commit CI failure observed after #12647 was merged.