[CI][NFC] Remove inaccurate comment in linux precommit yml #12841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
commented
Feb 27, 2024
| @@ -51,9 +51,6 @@ jobs: | |||
| name: Decide which Arc tests to run | |||
| needs: [build, detect_changes] | |||
| if: ${{ always() && !cancelled() && needs.build.outputs.build_conclusion == 'success' }} | |||
| # Github's ubuntu-* runners are slow to allocate. Use our CUDA runner since | |||
| # we don't use it for anything right now. | |||
| runs-on: [Linux, build] | |||
There was a problem hiding this comment.
The workflow is not valid. .github/workflows/sycl-linux-precommit.yml (Line: 51, Col: 5): Required property is missing: runs-on
@aelovikov-intel It seems runs-on is required. What am I supposed to put there? Is it ubuntu-latest or something?
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
sarnex
changed the title
sarnex
changed the title
aelovikov-intel
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't need it.