Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Clean up sub-group class API #12945

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

lbushi25
Copy link
Contributor

@lbushi25 lbushi25 commented Mar 7, 2024

This PR cleans up the API of the sub-group class by either removing functions that do not appear in the spec or marking them deprecated. The only exception is the set of load/store functions, which after some discussion with the spec team, it was suggested to leave them as is for now.

@lbushi25 lbushi25 marked this pull request as ready for review March 7, 2024 19:54
@lbushi25 lbushi25 requested a review from a team as a code owner March 7, 2024 19:54
@lbushi25 lbushi25 requested a review from bso-intel March 7, 2024 19:54
Copy link
Contributor

@KornevNikita KornevNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But I just noticed that sub_group is a class in SYCL2020 and a struct in our implementation. Is there any specific reason? Should we align this also? @intel/sycl-language-enabling-triage

@lbushi25
Copy link
Contributor Author

@intel/llvm-gatekeepers ping

@steffenlarsen steffenlarsen merged commit 2985395 into intel:sycl Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants