Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Add value_type alias to sycl::vec class #12960

Merged
merged 7 commits into from
Mar 11, 2024
Merged

[SYCL] Add value_type alias to sycl::vec class #12960

merged 7 commits into from
Mar 11, 2024

Conversation

lbushi25
Copy link
Contributor

@lbushi25 lbushi25 commented Mar 8, 2024

This PR adds the value_type alias for the data type of a sycl::vec object as described in the spec.

@lbushi25 lbushi25 requested a review from a team as a code owner March 8, 2024 15:27
@lbushi25 lbushi25 requested a review from bso-intel March 8, 2024 15:27
@lbushi25 lbushi25 mentioned this pull request Mar 8, 2024
Closed
@bader
Copy link
Contributor

bader commented Mar 8, 2024

Please, add a regression test.
@intel/sycl-language-enabling-triage, I suppose all SYCL core spec features missing in the DPC++ implementation should go with SYCL-CTS patch. Right?

@lbushi25
Copy link
Contributor Author

lbushi25 commented Mar 8, 2024

Please, add a regression test. @intel/sycl-language-enabling-triage, I suppose all SYCL core spec features missing in the DPC++ implementation should go with SYCL-CTS patch. Right?

Done

@lbushi25
Copy link
Contributor Author

lbushi25 commented Mar 8, 2024 •
edited
Loading

@bader Please have a brief look, I had to make a change to the file generic_type_traits.hpp at line 521. There were two overloads of the function template check that would result in identical instantiations so I added an enable clause to disable one of them in the case that it is instantiated with sycl::vec.

@lbushi25 @bader
Update sycl/test/regression/vec_value_type.cpp
e8ca9bb 
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
@lbushi25 lbushi25 requested a review from bader March 8, 2024 21:41
@lbushi25
Copy link
Contributor Author

lbushi25 commented Mar 8, 2024

@intel/llvm-gatekeepers ping.

@sommerlukas sommerlukas merged commit 33e5b10 into intel:sycl Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbushi25 @bader @cperkinsintel @sommerlukas