[SYCL][Graph] Re-enable immediate command list tests on Windows. #13685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
fabiomestre
force-pushed
the
fabio/enable_immediate_cm_windows
branch
from
4b19887
to
01917f7
Compare
EwanC
approved these changes
May 15, 2024
|
@intel/llvm-gatekeepers I think this is ready to merge. |
EwanC
added a commit
to reble/llvm
that referenced
this pull request
May 16, 2024
After PR intel#13685 merged to re-enabling running graphs tests on Windows with immediate command lists a non-deterministic leak has appeared in post-commit CI for a different PR https://github.com/intel/llvm/actions/runs/9097140304/job/25008463548 Don't run the test on Windows with immediate command lists until this can be investigated and fixed. ``` env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 env UR_L0_LEAKS_DEBUG=1 SYCL_ENABLE_DEFAULT_CONTEXTS=0 env ONEAPI_DEVICE_SELECTOR=level_zero:gpu D:\github\actions-runner\_work\llvm\llvm\build-e2e\Graph\Explicit\Output\host_task_single.cpp.tmp.out 2>&1 | d:\github\actions-runner\_work\llvm\llvm\install\bin\filecheck.exe D:\github\actions-runner\_work\llvm\llvm\llvm\sycl\test-e2e\Graph\Explicit\host_task_single.cpp --implicit-check-not=LEAK ```
martygrant
pushed a commit
that referenced
this pull request
May 16, 2024
After PR #13685 merged to re-enabling running graph E2E tests on Windows with immediate command lists, a non-deterministic leak has appeared in post-commit CI for a different PR https://github.com/intel/llvm/actions/runs/9097140304/job/25008463548 To keep CI green, don't run the test on Windows with immediate command lists until the leak can be investigated and fixed. ```quote env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 env UR_L0_LEAKS_DEBUG=1 SYCL_ENABLE_DEFAULT_CONTEXTS=0 env ONEAPI_DEVICE_SELECTOR=level_zero:gpu D:\github\actions-runner\_work\llvm\llvm\build-e2e\Graph\Explicit\Output\host_task_single.cpp.tmp.out 2>&1 | d:\github\actions-runner\_work\llvm\llvm\install\bin\filecheck.exe D:\github\actions-runner\_work\llvm\llvm\llvm\sycl\test-e2e\Graph\Explicit\host_task_single.cpp --implicit-check-not=LEAK # note: command had no output on stdout or stderr # error: command failed with exit status: 0xc0000409 # executed command: 'd:\github\actions-runner\_work\llvm\llvm\install\bin\filecheck.exe' 'D:\github\actions-runner\_work\llvm\llvm\llvm\sycl\test-e2e\Graph\Explicit\host_task_single.cpp' --implicit-check-not=LEAK # .---command stderr------------ # | command line:1:22: error: IMPLICIT-CHECK-NOT: excluded string found in input # | -implicit-check-not='LEAK' # | ^ # | <stdin>:3:54: note: found here # | zeContextCreate = 1 \---> zeContextDestroy = 0 ---> LEAK = 1 # | ^~~~ # | # | Input file: <stdin> # | Check file: D:\github\actions-runner\_work\llvm\llvm\llvm\sycl\test-e2e\Graph\Explicit\host_task_single.cpp # | # | -dump-input=help explains the following input dump. # | # | Input was: # | <<<<<< # | 1: Check balance of create/destroy calls # | 2: ---------------------------------------------------------- # | 3: zeContextCreate = 1 \---> zeContextDestroy = 0 ---> LEAK = 1 # | not:imp1 !~~~ error: no match expected # | 4: zeCommandQueueCreate = 0 \---> zeCommandQueueDestroy = 0 # | 5: zeModuleCreate = 0 \---> zeModuleDestroy = 0 # | 6: zeKernelCreate = 0 \---> zeKernelDestroy = 0 # | 7: zeEventPoolCreate = 1 \---> zeEventPoolDestroy = 0 ---> LEAK = 1 # | 8: zeCommandListCreateImmediate = 2 | # | . # | . # | . # | >>>>>> # `----------------------------- # error: command failed with exit status: 1 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests had been disabled as part of #12344 due to the windows level-zero drivers being out of date on CI. This PR re-enables the disabled tests since the driver version has since been updated and the tests are now passing.