Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Disable Windows test with L0 leak #13802

Merged
merged 1 commit into from
May 16, 2024

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented May 16, 2024

After PR #13685 merged to re-enabling running graph E2E tests on Windows with immediate command lists, a non-deterministic leak has appeared in post-commit CI for a different PR https://github.com/intel/llvm/actions/runs/9097140304/job/25008463548

To keep CI green, don't run the test on Windows with immediate command lists until the leak can be investigated and fixed.

env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 env UR_L0_LEAKS_DEBUG=1 SYCL_ENABLE_DEFAULT_CONTEXTS=0 env ONEAPI_DEVICE_SELECTOR=level_zero:gpu  D:\github\actions-runner\_work\llvm\llvm\build-e2e\Graph\Explicit\Output\host_task_single.cpp.tmp.out 2>&1 | d:\github\actions-runner\_work\llvm\llvm\install\bin\filecheck.exe D:\github\actions-runner\_work\llvm\llvm\llvm\sycl\test-e2e\Graph\Explicit\host_task_single.cpp --implicit-check-not=LEAK
# note: command had no output on stdout or stderr
# error: command failed with exit status: 0xc0000409
# executed command: 'd:\github\actions-runner\_work\llvm\llvm\install\bin\filecheck.exe' 'D:\github\actions-runner\_work\llvm\llvm\llvm\sycl\test-e2e\Graph\Explicit\host_task_single.cpp' --implicit-check-not=LEAK
# .---command stderr------------
# | command line:1:22: error: IMPLICIT-CHECK-NOT: excluded string found in input
# | -implicit-check-not='LEAK'
# |                      ^
# | <stdin>:3:54: note: found here
# |  zeContextCreate = 1 \---> zeContextDestroy = 0 ---> LEAK = 1
# |                                                      ^~~~
# | 
# | Input file: <stdin>
# | Check file: D:\github\actions-runner\_work\llvm\llvm\llvm\sycl\test-e2e\Graph\Explicit\host_task_single.cpp
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |           1: Check balance of create/destroy calls 
# |           2: ---------------------------------------------------------- 
# |           3:  zeContextCreate = 1 \---> zeContextDestroy = 0 ---> LEAK = 1 
# | not:imp1                                                          !~~~      error: no match expected
# |           4:  zeCommandQueueCreate = 0 \---> zeCommandQueueDestroy = 0  
# |           5:  zeModuleCreate = 0 \---> zeModuleDestroy = 0  
# |           6:  zeKernelCreate = 0 \---> zeKernelDestroy = 0  
# |           7:  zeEventPoolCreate = 1 \---> zeEventPoolDestroy = 0 ---> LEAK = 1 
# |           8:  zeCommandListCreateImmediate = 2 |  
# |           .
# |           .
# |           .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

@EwanC EwanC requested a review from a team as a code owner May 16, 2024 08:21
@EwanC
Copy link
Contributor Author

EwanC commented May 16, 2024

@intel/llvm-gatekeepers This is good to go

Copy link
Contributor

@dm-vodopyanov dm-vodopyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EwanC can you please add a comment to the tests highlighting that they were disabled on Windows due to

After PR intel#13685 merged to re-enabling
running graphs tests on Windows with immediate command lists a
non-deterministic leak has appeared in post-commit CI for a different
PR https://github.com/intel/llvm/actions/runs/9097140304/job/25008463548

Don't run the test on Windows with immediate command lists until this
can be investigated and fixed.

```
env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 env UR_L0_LEAKS_DEBUG=1 SYCL_ENABLE_DEFAULT_CONTEXTS=0 env ONEAPI_DEVICE_SELECTOR=level_zero:gpu  D:\github\actions-runner\_work\llvm\llvm\build-e2e\Graph\Explicit\Output\host_task_single.cpp.tmp.out 2>&1 | d:\github\actions-runner\_work\llvm\llvm\install\bin\filecheck.exe D:\github\actions-runner\_work\llvm\llvm\llvm\sycl\test-e2e\Graph\Explicit\host_task_single.cpp --implicit-check-not=LEAK
```
@EwanC EwanC force-pushed the disable_win_host-task_single branch from 3920e75 to 6a9c83d Compare May 16, 2024 11:16
@EwanC
Copy link
Contributor Author

EwanC commented May 16, 2024

Thanks @dm-vodopyanov i've added a comment. I've not created a GitHub issue to track this as we have an internal team issue to looking into this, but if having a GitHub issue to track this is desirable too, then I can create that.

@martygrant martygrant merged commit 1bfefc1 into intel:sycl May 16, 2024
14 checks passed
EwanC added a commit to reble/llvm that referenced this pull request May 21, 2024
PR intel#13802 disabled the L0 leak checking
in `host_task_single.cpp` for immediate command-lists on Windows.

However issue intel#13862 has highlighted
that this needs extended to also disabling the linux case due to CI fail
https://github.com/intel/llvm/actions/runs/9108501375/job/25040698422?pr=13801

```
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants