[SYCL][Matrix] Change packed to ext_intel_packed #9667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhaldi
reviewed
Jun 1, 2023
| @@ -18,7 +18,7 @@ namespace sycl { | |||
| __SYCL_INLINE_VER_NAMESPACE(_V1) { | |||
| namespace ext { | |||
| namespace intel::experimental::matrix::layout { | |||
| constexpr sycl::ext::oneapi::experimental::matrix::layout packed = | |||
| constexpr sycl::ext::oneapi::experimental::matrix::layout ext_intel_packed = | |||
| static_cast<sycl::ext::oneapi::experimental::matrix::layout>(2); | |||
| } | |||
There was a problem hiding this comment.
ext_intel_packed should be added to oneapi::experimental::matrix::layout
see Intel document in #7964
dkhaldi
reviewed
Jun 1, 2023
| @@ -228,7 +228,7 @@ inline __SYCL_ALWAYS_INLINE void joint_matrix_load( | |||
| Ptr, stride, __spv::MatrixLayout::ColumnMajor, | |||
| spv_scope_traits<Group>::value); | |||
| break; | |||
| case sycl::ext::intel::experimental::matrix::layout::packed: | |||
| case sycl::ext::intel::experimental::matrix::layout::ext_intel_packed: | |||
There was a problem hiding this comment.
we should not need to specify namespace anymore as this is now in the same namespace as joint_matrix
|
This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.