Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: timeouts deselection on GPU deselection #2059

Closed

Conversation

samir-nasibli
Copy link
Contributor

@samir-nasibli samir-nasibli commented Sep 18, 2024

Description

GPU timeouts deselections

  • Kmeans sparse

After initializing centroids via Kmeans_Init it gets stuck here

result = module.train(policy, params, X_table, centroids_table)

So actually the issue on onedal backend side.

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • The unit tests pass successfully.
  • I have run it locally and tested the changes extensively.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for debug; will be reverted.

@ethanglaser
Copy link
Contributor

/intelci: run

@samir-nasibli
Copy link
Contributor Author

/intelci: run

@icfaust
Copy link
Contributor

icfaust commented Sep 19, 2024

Looking at the deselections: is this just all sparse tests for kmeans?

@samir-nasibli
Copy link
Contributor Author

/intelci: run

@samir-nasibli
Copy link
Contributor Author

Looking at the deselections: is this just all sparse tests for kmeans?

Yeah, it seems only Kmeans sparse on GPU affected with timeouts. Expecting to have green CI jobs for GPU conformance validation with this PR

@samir-nasibli
Copy link
Contributor Author

/intelci: run

@samir-nasibli
Copy link
Contributor Author

Interesting fact: sklearnex own tests for the KMeans doesn't cover such cases from the conformance deselected.

@samir-nasibli
Copy link
Contributor Author

@ethanglaser
Copy link
Contributor

Should be covered by oneapi-src/oneDAL#2906 (if not feel free to re-open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants