Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PresenterWidget#internalAddToSlot always call performReset #4

Open
ibaca opened this issue Apr 3, 2020 · 0 comments
Open

PresenterWidget#internalAddToSlot always call performReset #4

ibaca opened this issue Apr 3, 2020 · 0 comments

Comments

@ibaca
Copy link
Member

ibaca commented Apr 3, 2020

This is a bit weird in some cases, for example, each time you use the popup-slot it will reset the whole hierarchy starting at the presenter used to reveal the slot, so if you add popups to the root presenter, then you reset the whole hierarchy.

What is the purpose of the rest? Define it.

Once defined. Review if resetting the presenter hierarchy makes sense each time you show a popup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant