Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Fix untranslated strings in facets #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mesemus
Copy link

@mesemus mesemus commented Dec 10, 2024

Description

User and domain translations are not working, even though they are wrapped in _(...). The reason is gettext is used which performs the translation during module initialization and not when the facets are rendered.

This PR fixes this by using lazy_gettext instead.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

User and domain translations are not working, even though they are wrapped
in `_(...)`. The reason is `gettext` is used which performs the translation
during module initialization and not when the facets are rendered.

This commit fixes this by using `lazy_gettext` instead.

Co-authored-by: Miroslav Simek <miroslav.simek@cesnet.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant