Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding notes to a variant causes problem #463

Open
AlistairNWard opened this issue Jan 6, 2022 · 0 comments
Open

Adding notes to a variant causes problem #463

AlistairNWard opened this issue Jan 6, 2022 · 0 comments
Labels
bug Something isn't working FIX NOW

Comments

@AlistairNWard
Copy link
Member

AlistairNWard commented Jan 6, 2022

Can be replicated in demo data.

Pick a variant from the left list and add a note. This automatically makes the variant of unknown significance and the variant appears in the final report.

Set the variant back to "Not reviewed". The following problems occur:

  1. The variant still appears in the findings as unknown significance
  2. The variant is missing from the left menu. The reviewed category is still listed as having a variant, but nothing is shown
  3. Every time you toggle between the findings page and the review variants page, the count of unknown significance variants in the findings workflow tab goes up by 1

I think this is caused because adding a note is changing the review status and this is causing conflicts. I would say we just remove this connection between notes and review status. Adding a note shouldn't modify the significance. Only significance determines appearance in the report

@AlistairNWard AlistairNWard added bug Something isn't working FIX NOW labels Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FIX NOW
Projects
None yet
Development

No branches or pull requests

1 participant