Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Acceptable HTTP status codes #3

Open
mithun opened this issue Apr 30, 2018 · 2 comments
Open

Add support for Acceptable HTTP status codes #3

mithun opened this issue Apr 30, 2018 · 2 comments

Comments

@mithun
Copy link
Contributor

mithun commented Apr 30, 2018

I have a use case where the HTTP check returns a 401 since I'm not providing credentials.

I'd like to submit a PR to allow acceptable HTTP Status codes other than 200. Please let me know if you have preferences on how this should be implemented.

@ionelmc
Copy link
Owner

ionelmc commented Nov 23, 2018

How about this sort of syntax: holdup http://abc 401=http://foo 3*=http://bar?

Maybe not = but +? Like holdup http://abc http+401://foo http+3*://bar

Also, http+3*+insecure://bar or http+insecure+3*://bar vs 3*=http+insecure://bar?

I think the + would be cleanest to implement but haven't really looked - what do you think?

@ionelmc
Copy link
Owner

ionelmc commented Apr 15, 2024

So I've been thinking about this again, and I guess glob syntax with plus sign should be fine.

These should be acceptable (all would go into fnmatch):

http+404://blabla
http+40[13]://blabla
http+40?://blabla
http+4*://blabla
http+4://blabla (identical)
http+[45]://blabla
http+4*+5*://blabla (identical)
http+4+5://blabla (identical)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants