-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GenericAWSRequestHandler
do the JSON deserialization and handler calling
#162
Labels
Milestone
Comments
XerTheSquirrel
added
the
enhancement
Improves the library by adding a new feature!
label
Aug 31, 2018
I had a thought that compatibility is no issue at all, these are two different interfaces and they can be implemented since they provide two different methods (they have different descriptors). This means:
If this is done, then there would have to be an internal extra method which forwards to the desired code to be executed, to prevent the input object being processed multiple times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The raw JSON data is passed in the entry point implements
RequestStreamHandler
. Since this gives access to the raw JSON data, we can handle JSON deserialization ourselves and then support calling into eitherRequestHandler
or just forwarding the streams toRequestStreamHandler
.This will have the advantage of doing JSON deserialization any way we want rather than forcing how Amazon does it.
This will break compatibility if any other code uses
GenericAWSRequestHandler
as aRequestHandler
(a wrapper on top of IOpipe?).This should be researched.
The text was updated successfully, but these errors were encountered: