Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in -core should throw instead of being returned #336

Open
mrickard opened this issue Jul 3, 2019 · 0 comments
Open

Errors in -core should throw instead of being returned #336

mrickard opened this issue Jul 3, 2019 · 0 comments
Assignees

Comments

@mrickard
Copy link
Contributor

mrickard commented Jul 3, 2019

Currently the pre:invoke hook in src/index has a try/catch block which (when catching) sends an error report to the original callback and returns the error. If the error was instead thrown, AWS would pick it up as an error.

There's a test in catchTypeError that expects the error to be returned and not thrown; it requires a fair amount of refactoring.

@mrickard mrickard self-assigned this Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant