Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files: "Inspect" context menu broken due to /ipfs/ prefix in URL #2306

Closed
lidel opened this issue Nov 29, 2024 · 1 comment · Fixed by #2305
Closed

Files: "Inspect" context menu broken due to /ipfs/ prefix in URL #2306

lidel opened this issue Nov 29, 2024 · 1 comment · Fixed by #2305
Assignees
Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP released

Comments

@lidel
Copy link
Member

lidel commented Nov 29, 2024

Seems we have a regression in UI, ipld explorer stopped normalizing paths and now errors:

2024-11-29_17-27

2024-11-29_17-28

I'll fix it in #2305

@lidel lidel added need/triage Needs initial labeling and prioritization kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours and removed need/triage Needs initial labeling and prioritization labels Nov 29, 2024
@lidel lidel self-assigned this Nov 29, 2024
lidel added a commit that referenced this issue Nov 29, 2024
@lidel lidel closed this as completed in 0412970 Nov 29, 2024
ipfs-gui-bot pushed a commit that referenced this issue Nov 30, 2024
## [4.4.1](v4.4.0...v4.4.1) (2024-11-30)

 CID `bafybeiatztgdllxnp5p6zu7bdwhjmozsmd7jprff4bdjqjljxtylitvss4`

 ---

### Bug Fixes

* add lithuanian to languages.json ([#2293](#2293)) ([40c512b](40c512b))
* analyze script doesn't persist stats.json ([#2290](#2290)) ([dbbdd70](dbbdd70))
* **explore:** browsing chunked files and inspecting via context menu ([#2305](#2305)) ([0412970](0412970)), closes [#2306](#2306)

### Trivial Changes

* **ci:** add CAR file directly to cluster ([#2304](#2304)) ([e2ae110](e2ae110))
* **ci:** no replication factor when pinning - use cluster's default ([#2302](#2302)) ([81b8f29](81b8f29))
* **ci:** set cluster pin timeout to 30m ([4b8fc00](4b8fc00))
* **ci:** udpate artifact actions to v4 ([#2292](#2292)) ([305908f](305908f))
* **ci:** use repo in offline mode ([eaf63ed](eaf63ed))
* pull new translations ([#2291](#2291)) ([bfe7e40](bfe7e40))
* pull transifex translations ([#2296](#2296)) ([502abd4](502abd4))
* pull transifex translations ([#2303](#2303)) ([89c094b](89c094b))
* size-related labels in Files screen ([#2295](#2295)) ([49019d4](49019d4))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 4.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

MattWong-ca pushed a commit to MattWong-ca/ipfs-webui that referenced this issue Dec 14, 2024
…pfs#2305)

* fix(explore): chunked files

This includes latest ipld-explorer-components with fix from
ipfs/ipld-explorer-components#462

also bumped kubo and caniuse and non-breaking audit suggestions

* fix(files): Inspect via context menu

Closes ipfs#2306
MattWong-ca pushed a commit to MattWong-ca/ipfs-webui that referenced this issue Dec 14, 2024
## [4.4.1](ipfs/ipfs-webui@v4.4.0...v4.4.1) (2024-11-30)

 CID `bafybeiatztgdllxnp5p6zu7bdwhjmozsmd7jprff4bdjqjljxtylitvss4`

 ---

### Bug Fixes

* add lithuanian to languages.json ([ipfs#2293](ipfs#2293)) ([40c512b](ipfs@40c512b))
* analyze script doesn't persist stats.json ([ipfs#2290](ipfs#2290)) ([dbbdd70](ipfs@dbbdd70))
* **explore:** browsing chunked files and inspecting via context menu ([ipfs#2305](ipfs#2305)) ([0412970](ipfs@0412970)), closes [ipfs#2306](ipfs#2306)

### Trivial Changes

* **ci:** add CAR file directly to cluster ([ipfs#2304](ipfs#2304)) ([e2ae110](ipfs@e2ae110))
* **ci:** no replication factor when pinning - use cluster's default ([ipfs#2302](ipfs#2302)) ([81b8f29](ipfs@81b8f29))
* **ci:** set cluster pin timeout to 30m ([4b8fc00](ipfs@4b8fc00))
* **ci:** udpate artifact actions to v4 ([ipfs#2292](ipfs#2292)) ([305908f](ipfs@305908f))
* **ci:** use repo in offline mode ([eaf63ed](ipfs@eaf63ed))
* pull new translations ([ipfs#2291](ipfs#2291)) ([bfe7e40](ipfs@bfe7e40))
* pull transifex translations ([ipfs#2296](ipfs#2296)) ([502abd4](ipfs@502abd4))
* pull transifex translations ([ipfs#2303](ipfs#2303)) ([89c094b](ipfs@89c094b))
* size-related labels in Files screen ([ipfs#2295](ipfs#2295)) ([49019d4](ipfs@49019d4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants