Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs get does not support zip compression #6104

Open
qiwaa opened this issue Mar 20, 2019 · 4 comments
Open

ipfs get does not support zip compression #6104

qiwaa opened this issue Mar 20, 2019 · 4 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/community-input Needs input from the wider community P2 Medium: Good to have, but can wait until someone steps up topic/gateway Topic gateway

Comments

@qiwaa
Copy link
Contributor

qiwaa commented Mar 20, 2019

Version information:

go-ipfs version: 0.4.19-dev-
Repo version: 7
System version: amd64/darwin
Golang version: go1.11.1

Type:

enhancement

Description:

ipfs get does not support zip compression. Zip is used more widely in windows.
@Stebalien Stebalien added the kind/enhancement A net-new feature or improvement to an existing feature label Mar 20, 2019
@magik6k
Copy link
Member

magik6k commented Mar 22, 2019

This should be relatively simple to do:

  1. Implement ZipWriter in go-ipfs-files based on https://github.com/ipfs/go-ipfs-files/blob/master/tarwriter.go#L16
  2. Add --zip option to ipfs got and make it swap this to the zip writer

@magik6k magik6k added the help wanted Seeking public contribution on this issue label Mar 22, 2019
@Kubuxu
Copy link
Member

Kubuxu commented Mar 27, 2019

Do we really need this feature? One of the main reasons why we have a tar writer is because we use tar format for API we essentially get tar archive output for free by writing the API output to a file (and maybe compressing it on the way).

@Kubuxu Kubuxu added need/community-input Needs input from the wider community and removed help wanted Seeking public contribution on this issue labels Mar 27, 2019
@qiwaa
Copy link
Contributor Author

qiwaa commented Apr 9, 2019

Yes, we use tar for writing the API output to a file. But in some windows systems, we can't open tar.

@Stebalien Stebalien added topic/icebox Topic icebox and removed topic/icebox Topic icebox labels May 16, 2019
@lidel lidel mentioned this issue Jul 30, 2021
Closed
@lidel
Copy link
Member

lidel commented Jul 30, 2021 •
edited
Loading

FWIW support for command line tar (BSD) has been included in Microsoft Windows since Windows 10 (2019):
https://techcommunity.microsoft.com/t5/containers/tar-and-curl-come-to-windows/ba-p/382409

Still, having support for ZIP would improve UX of #8234 significantly, allowing for gateway links to be used directly in places where TAR is not a feasible option.

@lidel lidel added P2 Medium: Good to have, but can wait until someone steps up topic/gateway Topic gateway labels Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/community-input Needs input from the wider community P2 Medium: Good to have, but can wait until someone steps up topic/gateway Topic gateway
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lidel @Stebalien @Kubuxu @magik6k @qiwaa