Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go-libp2p-kad-dht v0.26.1 #80

Merged
merged 3 commits into from
Aug 21, 2024
Merged

fix: go-libp2p-kad-dht v0.26.1 #80

merged 3 commits into from
Aug 21, 2024

Conversation

2color
Copy link
Member

@2color 2color commented Aug 21, 2024

@2color 2color requested a review from lidel August 21, 2024 12:26
@lidel lidel changed the title fix: bump deps fix: go-libp2p-kad-dht v0.26.1 Aug 21, 2024
Copy link

Suggested version: 0.4.2

Comparing to: v0.4.1 (diff)

Changes in configuration file(s):

(empty)

gorelease says:

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x5e6a2f]

goroutine 243 [running]:
go/types.(*Checker).handleBailout(0xc00080e400, 0xc0008c3c10)
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/check.go:367 +0x88
panic({0x6a6260?, 0x8e1520?})
	/opt/hostedtoolcache/go/1.22.6/x64/src/runtime/panic.go:770 +0x132
go/types.(*StdSizes).Sizeof(0x0, {0x758110, 0x8e49a0})
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/sizes.go:228 +0x30f
go/types.(*Config).sizeof(...)
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/sizes.go:333
go/types.representableConst.func1({0x758110?, 0x8e49a0?})
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/const.go:76 +0x9e
go/types.representableConst({0x759f18, 0x8d9c40}, 0xc00080e400, 0x8e49a0, 0xc0008c2028)
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/const.go:92 +0x192
go/types.(*Checker).representation(0xc00080e400, 0xc00032a4c0, 0x8e49a0)
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/const.go:256 +0x65
go/types.(*Checker).implicitTypeAndValue(0xc00080e400, 0xc00032a4c0, {0x758110, 0x8e49a0})
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/expr.go:375 +0x2d7
go/types.(*Checker).convertUntyped(0xc00080e400, 0xc00032a4c0, {0x758110, 0x8e49a0})
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/const.go:289 +0x3f
go/types.(*Checker).matchTypes(0xc00080e400, 0xc00032a480, 0xc00032a4c0)
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/expr.go:926 +0x79
go/types.(*Checker).binary(0xc00080e400, 0xc00032a480, {0x7594c8, 0xc0007ac0f0}, {0x7590d8, 0xc000035420}, {0x7599d8, 0xc0000354c0}, 0x28, 0x133)
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/expr.go:800 +0x166
go/types.(*Checker).exprInternal(0xc00080e400, 0x0, 0xc00032a480, {0x7594c8, 0xc0007ac0f0}, {0x0, 0x0})
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/expr.go:1416 +0x206
go/types.(*Checker).rawExpr(0xc00080e400, 0x0, 0xc00032a480, {0x7594c8?, 0xc0007ac0f0?}, {0x0?, 0x0?}, 0x0)
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/expr.go:979 +0x19e
go/types.(*Checker).expr(0xc00080e400, 0x758a48?, 0xc00032a480, {0x7594c8?, 0xc0007ac0f0?})
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/expr.go:1513 +0x30
go/types.(*Checker).stmt(0xc00080e400, 0x0, {0x759678, 0xc0007c4100})
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/stmt.go:570 +0x11f2
go/types.(*Checker).stmtList(0xc00080e400, 0x0, {0xc0000356e0?, 0x0?, 0x0?})
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/stmt.go:121 +0x85
go/types.(*Checker).funcBody(0xc00080e400, 0x758110?, {0xc00079c098?, 0x8e4b80?}, 0xc00032a0c0, 0xc0007ac180, {0x0?, 0x0?})
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/stmt.go:41 +0x331
go/types.(*Checker).funcDecl.func1()
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/decl.go:852 +0x3a
go/types.(*Checker).processDelayed(0xc00080e400, 0x0)
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/check.go:467 +0x162
go/types.(*Checker).checkFiles(0xc00080e400, {0xc0007ae000, 0x1, 0x1})
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/check.go:411 +0x1cc
go/types.(*Checker).Files(...)
	/opt/hostedtoolcache/go/1.22.6/x64/src/go/types/check.go:372
golang.org/x/tools/go/packages.(*loader).loadPackage(0xc0000d40e0, 0xc0006ec810)
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:1037 +0x932
golang.org/x/tools/go/packages.(*loader).loadRecursive.func1()
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:847 +0x1a9
sync.(*Once).doSlow(0x0?, 0x0?)
	/opt/hostedtoolcache/go/1.22.6/x64/src/sync/once.go:74 +0xc2
sync.(*Once).Do(...)
	/opt/hostedtoolcache/go/1.22.6/x64/src/sync/once.go:65
golang.org/x/tools/go/packages.(*loader).loadRecursive(0x0?, 0x0?)
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:835 +0x4a
golang.org/x/tools/go/packages.(*loader).loadRecursive.func1.1(0x0?)
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:842 +0x26
created by golang.org/x/tools/go/packages.(*loader).loadRecursive.func1 in goroutine 218
	/home/runner/go/pkg/mod/golang.org/x/tools@v0.2.0/go/packages/packages.go:841 +0x94

gocompat says:

HEAD is now at 2f2fb2e fix: enable hole punching and libp2p listener config (#79)
Previous HEAD position was 2f2fb2e fix: enable hole punching and libp2p listener config (#79)
Switched to branch 'main'
Your branch is up to date with 'origin/main'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to main. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, added changelog + version bump + shiping this as v0.4.2

@lidel lidel merged commit 02b8190 into main Aug 21, 2024
11 checks passed
@lidel lidel deleted the bump-kad branch August 21, 2024 22:24
@2color
Copy link
Member Author

2color commented Aug 22, 2024

Is the changelog updated manually?

@lidel
Copy link
Member

lidel commented Aug 30, 2024

@2color no, I've updated it in 48395ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peer routing fails for peers behind NAT (with /p2p-circuit)
2 participants