[Substrait] Add pattern that eliminates yielding of input fields. #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
substrait-emit-deduplication-project-yield-emit
branch
2 times, most recently
from
9758c77
to
f12a311
Compare
jpienaar
reviewed
Jul 22, 2024
|
|
||
| func.func private @f(si32) -> si1 | ||
|
|
||
| substrait.plan version 0 : 42 : 1 { |
There was a problem hiding this comment.
Lets add descriptions for these to make it easy to read (the pattern name is close as quite descriptive)
jpienaar
approved these changes
Jul 22, 2024
ingomueller-net
changed the title
This PR adds a pattern to the emit deduplication pass that removes values yielded from `project` that are `field_reference`s of top-level input fields and expresses them through an `emit` op instead. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
force-pushed
the
substrait-emit-deduplication-project-yield-emit
branch
from
f12a311
to
7304bf3
Compare
ingomueller-net
deleted the
substrait-emit-deduplication-project-yield-emit
branch
ingomueller-net
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
…ee-org/iree-llvm-sandbox#847) This PR adds a pattern to the emit deduplication pass that removes values yielded from `project` that are `field_reference`s of top-level input fields and expresses them through an `emit` op instead. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
…ee-org/iree-llvm-sandbox#847) This PR adds a pattern to the emit deduplication pass that removes values yielded from `project` that are `field_reference`s of top-level input fields and expresses them through an `emit` op instead. Signed-off-by: Ingo Müller <ingomueller@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on and, therefor, includes #846.
This PR adds a pattern to the emit deduplication pass that removes
values yielded from
projectthat arefield_references of top-levelinput fields and expresses them through an
emitop instead.