Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set suitable defaults for new features #219

Open
bh9 opened this issue Mar 26, 2021 · 2 comments
Open

set suitable defaults for new features #219

bh9 opened this issue Mar 26, 2021 · 2 comments
Assignees
Milestone

Comments

@bh9
Copy link
Contributor

bh9 commented Mar 26, 2021

When features are added, the metalnx.properties file changes. When changing version, there should be defaults in place such that the file doesn't need to change unless one wants to enable one of the new features. This is not the case with pluggable search, as the startup errors out with

2021-03-25 16:44:47 WARN  XmlWebApplicationContext:551 - Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException:
...
nested exception is java.lang.IllegalArgumentException: Invalid boolean value [${pluggablesearch.enabled}]

Checking for unset values and assuming them to be false would mean that these wouldn't actually have to be set, so upgrades could be done without first changing the properties file

@trel
Copy link
Contributor

trel commented Mar 26, 2021

Completely agree.

We should have a strong default for every setting, and log messages saying that default value was being used, for admin discoverability along the way.

@trel trel added this to the 2.4.0 milestone Mar 26, 2021
@trel
Copy link
Contributor

trel commented Jun 4, 2021

out of time - bumping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants