Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Tests: Resolve Test Dependency on Machine Deletion to Prevent Inconsistent Results #380

Open
so-sahu opened this issue Aug 20, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@so-sahu
Copy link
Contributor

so-sahu commented Aug 20, 2024

Description:

Currently, the integration tests have dependencies where one test relies on the successful completion of another, specifically regarding machine deletion. If the deletion of a machine is not fully completed before the execution of the next test, it can cause inconsistencies, such as in the ListMachine test case.

In the ListMachine test, the current expectation is that the machine count should be 1. However, if the previous test has not finished deleting a machine, the list may include more than one machine, causing the test to fail.

To ensure reliable and independent test execution, this dependency issue needs to be resolved. The tests should be refactored to ensure that each test can run independently without relying on the state changes (such as machine deletion) from the previous tests.

Ref: https://github.com/ironcore-dev/libvirt-provider/actions/runs/10451444191/job/28937878022?pr=370

@lukas016
Copy link
Contributor

this issue is solving in refactoring of integration tests. PR is here #345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants