Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDTB on Windows? #84

Open
DavidBrainard opened this issue May 31, 2017 · 5 comments
Open

RDTB on Windows? #84

DavidBrainard opened this issue May 31, 2017 · 5 comments

Comments

@DavidBrainard
Copy link
Contributor

DavidBrainard commented May 31, 2017

Has anyone tried RDTB on Windows? We just tried under Windows 7 and it failed because a command that works for Mac/Linux fails at the command line. I didn't try very hard to push further, but am curious as to whether anyone has gotten it to work?

If so and if you had to modify the code, please share the patch and I'll work on inserting it into the distribution with a conditional on the type of machine.

@beyondmetis
Copy link

Here's my modified external\gradle\gradleFetchArtifact.m file that works for windows. This modification requires cygwin to work.

gradleFetchArtifact.zip

I could make a pull request if requiring cygwin is acceptable.

@DavidBrainard
Copy link
Contributor Author

Thanks!

We are completely Windows ignorant. But if like us, you found that RDTB doesn't work on Windows, I don't think adding your fix can do any harm as long as it doesn't change what happens for Linux/Mac.

What is cygwin? I think it is OK to depend on it if the code checks for its existence and provides a helpful message about how to get and install it if it isn't there.

And yes, once you have this ready to go, I think a PR is the right way to submit it.

DB

@beyondmetis
Copy link

No problem. I also prefer Linux/Mac myself, but it's nice to have compatibility.

Cygwin is a package of Linux command line utilities built for windows. It includes a bash shell, which is assumed to exist by the gradleFetchArtifact script. I'll put together some self-documented code for the pull request after testing with Windows/Mac. I would think that Linux should be covered if Mac still works.

@DavidBrainard
Copy link
Contributor Author

Great, thanks.

@beyondmetis
Copy link

See #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants