-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The examples from Bootstrap Italia API do not show icons. #1142
Comments
I think we inserted the bug here https://github.com/italia/designers.italia.it/pull/907/files @bfabio @astagi Let's fix it ASAP. |
Update. This newly merged #1137 will fix (revert) the bug entered on November 15. For example, see the Toolbar component. But I just found that there are some components (e.g., Popover with icon) that still have the problem of not showing the icon. Perhaps this is another bug with the way we have been implementing BSI for a while now that we never discovered. We need to investigate more next week @astagi @bfabio . |
@astagi fyi take a look |
Does a discussion already exist on the topic you are interested in, or on a similar topic?
What
See comparison. Tab with icon.
![immagine](https://private-user-images.githubusercontent.com/6736103/290871298-36b04c34-c444-4a03-ad04-808a7da03ebb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5NjE0NzEsIm5iZiI6MTcyNTk2MTE3MSwicGF0aCI6Ii82NzM2MTAzLzI5MDg3MTI5OC0zNmIwNGMzNC1jNDQ0LTRhMDMtYWQwNC04MDhhN2RhMDNlYmIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTBUMDkzOTMxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODAxYzBhNTc0MWIwMmZkMDU1NjQ5ZTgwZjQ1ODIxZWVlOGFiNzExOGE0MTljZWRlZmVhOTNkOGFjNzY3MTRkYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.gBLH6RNE7vxuYdJ3LzFh3QzOWHReT5NLznykm_C8JOE)
Left Documentation of the design system. Right Documentation of Bootstrap Italia.
On the left the svg/use has
href="/bootstrap-italia/dist/svg/sprites.svg#en-file
and our website has/dist/svg/sprites.svg#en-file
.Did something change with one of the latest versions of Bootstrap Italia? Or did we do something? 🤔 Could it be related to #1122?
@astagi @bfabio
Why
🔴 all the icons are gone, in all the DS examples...
Context
No response
More
No response
The text was updated successfully, but these errors were encountered: