Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy URL → S3 URL should not URI encode object key #16551

Closed
dkocher opened this issue Nov 19, 2024 Discussed in #16550 · 0 comments · Fixed by #16552
Closed

Copy URL → S3 URL should not URI encode object key #16551

dkocher opened this issue Nov 19, 2024 Discussed in #16550 · 0 comments · Fixed by #16552
Assignees
@dkocher
Labels
s3 AWS S3 Protocol Implementation
Milestone
9.1

Comments

@dkocher
Copy link
Contributor

dkocher commented Nov 19, 2024

The s3:// URLs introduced with #8753 should not encode the object key to allow using with aws s3 CLI.
@dkocher dkocher added the s3 AWS S3 Protocol Implementation label Nov 19, 2024
@dkocher dkocher added this to the 9.1 milestone Nov 19, 2024
@dkocher dkocher self-assigned this Nov 19, 2024
dkocher added a commit that referenced this issue Nov 19, 2024
@dkocher
Fix #16551.
6f70dc3
@dkocher dkocher linked a pull request Nov 19, 2024 that will close this issue
Fix #16551. #16552
Merged
dkocher added a commit that referenced this issue Nov 20, 2024
@dkocher
Merge pull request #16552 from iterate-ch/bugfix/GH-16551
9eb4c59 
Fix #16551.
dkocher added a commit that referenced this issue Nov 26, 2024
@dkocher
Merge pull request #16581 from iterate-ch/bugfix/GH-16551-url
ef0b879 
Do not enforce valid URI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkocher dkocher

Labels
s3 AWS S3 Protocol Implementation
Projects
None yet
Milestone
9.1
Development

Successfully merging a pull request may close this issue.

Fix #16551. iterate-ch/cyberduck
1 participant
@dkocher