Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SMB protocol support #15020

Merged
merged 79 commits into from
Sep 20, 2023
Merged

Add SMB protocol support #15020

merged 79 commits into from
Sep 20, 2023

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Aug 21, 2023 •
edited
Loading

Fix #5368. In addition to #15009 this adds the following features

Test Matrix

  • Windows 2016 Server 10.0.14393 SMB_3_1_1
  • Linux Samba SMB_3_1_1
  • macOS 13.5 (22G74) SMB_3_0_2

@dkocher dkocher added this to the 9.0 milestone Aug 21, 2023
@dkocher dkocher self-assigned this Aug 21, 2023
@dkocher dkocher requested a review from a team as a code owner August 21, 2023 20:32
@dkocher dkocher marked this pull request as draft August 21, 2023 20:34
@dkocher dkocher force-pushed the feature/GH-5368-review branch from a5eeee4 to bd45eff Compare August 22, 2023 07:19
@dkocher dkocher mentioned this pull request Aug 22, 2023
Merged
1 task
@dkocher dkocher force-pushed the feature/GH-5368-review branch 2 times, most recently from 22001a5 to 1d77425 Compare August 24, 2023 10:26
@dkocher
Copy link
Contributor Author

dkocher commented Aug 24, 2023

Listing available shares when authenticated with SMB running on macOS we currently see the same error as described in 1

Footnotes

  1. Share listing on macOS (High) Sierra rapid7/smbj-rpc#129 ↩

@dkocher dkocher marked this pull request as ready for review August 24, 2023 12:28
@dkocher dkocher marked this pull request as draft August 25, 2023 06:09
@dkocher dkocher force-pushed the feature/GH-5368-review branch 2 times, most recently from 1625596 to 46bdc57 Compare August 27, 2023 19:22
@dkocher dkocher marked this pull request as ready for review August 27, 2023 19:22
@dkocher dkocher requested a review from ylangisc August 27, 2023 20:43
@dkocher dkocher requested a review from AliveDevil August 28, 2023 07:03
@dkocher dkocher added the smb Server Message Block (SMB) label Aug 28, 2023
@dkocher dkocher force-pushed the feature/GH-5368-review branch 2 times, most recently from d43e129 to aff72a8 Compare August 30, 2023 14:28
dkocher added 18 commits September 8, 2023 10:04
@dkocher
Fix test.
b535f86
@dkocher
Use create disposition depending on exists flag in status.
27505b8
@dkocher
Review failure handling.
c9a45a0
@dkocher
Move configuration to inner class.
60b0657
@dkocher
Delete unused.
aaa1766
@dkocher
Delete support for share name in profile context.
857757d
@dkocher
Review container lifecycle.
ab63c9b
@dkocher
Add missing listener notifications.
33ba20c
@dkocher
Fix tests.
1171a76
@dkocher
Use \ as delimiter between realm and username.
80c36b4
@dkocher
Remote copy is only possible between files on the same server.
c34a11d
@dkocher
Review failure handling. STATUS_ACCESS_DENIED is returned when SMB2_I…
c093fbb 
…OCTL command fails.
@dkocher
Disallow move between shares.
485c9cb
@dkocher
No SO_TIMEOUT on idling transport connection but infinite wait.
cb22596
@dkocher
Do not require signing to resolve the issue "Cannot require message s…
d33227c 
…igning when authenticating with a guest account" when connecting to guest share.
@dkocher
Map to interoperability failure by default.
9cb68ca
@dkocher
Add defaults for configuration.
88c2eaa
@dkocher
No support to save share name as we are running outside of login cont…
fd9eda8 
…ext.
@dkocher dkocher force-pushed the feature/GH-5368-review branch from 2a9236b to fd9eda8 Compare September 8, 2023 08:04
AliveDevil
AliveDevil requested changes Sep 20, 2023
View reviewed changes
profiles/default/SMB.cyberduckprofile Outdated Show resolved Hide resolved
@AliveDevil
Copy link
Contributor

UPN (user@domain.com) is not supported by NTLM, requires Negotiate/Kerberos - thus support isn't possible.

@AliveDevil
Copy link
Contributor

Decided to post-pone Windows Integrated Authentication/SSO - instructions unclear.

@dkocher dkocher requested a review from AliveDevil September 20, 2023 14:54
@dkocher dkocher merged commit 010f646 into master Sep 20, 2023
5 checks passed
@dkocher dkocher deleted the feature/GH-5368-review branch September 20, 2023 15:36
@ajbaab ajbaab mentioned this pull request Sep 20, 2023
Closed
@dkocher dkocher modified the milestones: 9.0, 8.7.0 May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliveDevil AliveDevil AliveDevil approved these changes

@ylangisc ylangisc ylangisc approved these changes

Assignees

@dkocher dkocher

Labels
smb Server Message Block (SMB)
Projects
None yet
Milestone
8.7.0
Development

Successfully merging this pull request may close these issues.

Support for Samba (SMB) protocol
4 participants
@dkocher @AliveDevil @ylangisc @oaehmka