decoder: increase intermediate bitstream buffer size #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier, the size for the intermediate bitstream buffer was hard-coded creating the possibility of buffer overflows in case of large data. This has been resolved by defining this buffer size' based on max height and max width. Bug: oss-fuzz:56898 Bug: 273291708 Test: mpeg2_dec_fuzzer (cherry picked from https://partner-android-review.googlesource.com/q/commit:3a10c1f25185b5427e478454d73ded7b3bcac94a) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3cb820f35397cd9ebfd49030004994a63e48f59b) Merged-In: Ifc8cbbdf46ced7dc1586798be111ef6729d0d808 Change-Id: Ifc8cbbdf46ced7dc1586798be111ef6729d0d808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, the size for the intermediate bitstream buffer was hard-coded creating the possibility of buffer overflows in case of large data. This has been resolved by defining this buffer size' based on max height and max width.
Bug: oss-fuzz:56898
Bug: 273291708
Test: mpeg2_dec_fuzzer
(cherry picked from https://partner-android-review.googlesource.com/q/commit:3a10c1f25185b5427e478454d73ded7b3bcac94a) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:3cb820f35397cd9ebfd49030004994a63e48f59b) Merged-In: Ifc8cbbdf46ced7dc1586798be111ef6729d0d808 Change-Id: Ifc8cbbdf46ced7dc1586798be111ef6729d0d808