Unable to auto download mods with brackets in their file names #2983
Labels
Comments
|
So far I am finding it will be non-trivial to fix this. The invalid URL is caused by a redirect being processed within a library used by my tool It's really not a valid URL even though, yes, there's a "common practice" of fixing up square brackets that people incorrectly include in URLs. The mod or modpack author should really fix their metadata. I'll take a little more time to investigate, but I will quickly get annoyed having to work around other people's mistakes. |
|
I hadn't considered that it could be a redirect and therefore somewhat out of your control, that's very unfortunate. Would it instead be possible to handle the |
|
Speaking of which, the only practical solution I can think is for you to pre-download that particular one and put it in The startup should grab the file form there rather than attempting to download. |
|
I've tried that, but it still attempts to download the mod in question. Is there some sort of naming convention? I'm sure I'm doing something wrong but I can't figure out what. |
|
It turns out I remembered the logic wrong. It was only looking in downloads directory when the mod didn't declare a URL. I'm working on enhancing that now. |
This was referenced Jul 13, 2024
Merged
|
After this build pushes, re-pull the image and see if that also solves the download directory approach for you https://github.com/itzg/docker-minecraft-server/actions/runs/9921068538 |
|
Unfortunately that doesn't seem to have made a difference. Log |
|
Hmm, that's odd. For comparison here's the compose file I'm using: services:
mc:
image: itzg/minecraft-server:java8
ports:
- "25565:25565"
environment:
EULA: true
MOD_PLATFORM: AUTO_CURSEFORGE
CF_PAGE_URL: https://www.curseforge.com/minecraft/modpacks/meatballcraft
# from .env
CF_API_KEY: ${CF_API_KEY}
MEMORY: 4G
volumes:
- ./downloads:/downloads:ro
- data:/data
volumes:
data:and my file setup looks like |
|
...after that it looks like there's an unrelated bug I'm seeing that I'll investigate: |
|
Ah, I had the mods in Worth noting: the ItemFavorites mod doesn't seem to have been copied to the mods folder |
|
Yep it turns out you're seeing symptoms of the new bug I found :) |
This was referenced Jul 13, 2024
|
This build should fix the remaining issues. https://github.com/itzg/docker-minecraft-server/actions/runs/9922092016 |
|
Thank you! It all works now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the problem
While trying to auto download the "meatballcraft" modpack, the server crashes with the error
This seems fixable via this SO solution or otherwise URL encoding brackets in URLs (
[ -> %5Band] -> %5Dto be specific)Container definition
Container logs
The text was updated successfully, but these errors were encountered: