-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera and cropping view on Android 15 #2102
Comments
Update: Just tested this on my real Pixel 8 Pro with Android 15, and the issue also appears there |
having the same issue |
Also getting this. It's due to this: https://developer.android.com/about/versions/15/behavior-changes-15#window-insets Edit: Yalantis/uCrop#913 |
Here's the patch file I made for Bluesky: https://github.com/bluesky-social/social-app/blob/main/patches/react-native-image-crop-picker+0.41.6.patch Feel free to make a PR, but it is a temporary solution. It would be better to handle the insets properly |
thanks, i already made a patch. Please add it in library. thanks
Almas Tabssam
Senior React Native Developer
Mobile No: +923137833381
…On Fri, 10 Jan 2025 at 02:59, Samuel Newman ***@***.***> wrote:
Here's the patch file I made for Bluesky:
https://github.com/bluesky-social/social-app/blob/main/patches/react-native-image-crop-picker+0.41.6.patch
Feel free to make a PR, but it is a temporary solution. It would be better
to handle the insets properly
—
Reply to this email directly, view it on GitHub
<#2102 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AREENHLHCY6PLNYRT3U2C5L2J3WK5AVCNFSM6AAAAABP6W5Q6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBRGMZDCOBSGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I'd love to but I am not a maintainer and I don't know Android dev :P |
Version
Tell us which versions you are using:
Platform
Tell us to which platform this issue is related
Expected behaviour
Camera picker should have device insets to make sure elements are not drawn underneath the system bars
Actual behaviour
Camera picker and cropper draw under system bars in some circumstances
Steps to reproduce
Setup project which targets Android 15, and uses the camera image crop picker
Run on Android virtual device "Pixel 8 Pro - API 35-ext13"
Open the camera picker and cropper, and notice the system bars cover the top and bottom
Note that I cannot reproduce this on a real Pixel 8 Pro with Android 14 and edge-to-edge mode enabled but can reproduce on a real Pixel 8 Pro with Android 15
Attachments
The text was updated successfully, but these errors were encountered: