Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera and cropping view on Android 15 #2102

Open
1 of 2 tasks
flipflop97 opened this issue Oct 15, 2024 · 7 comments
Open
1 of 2 tasks

Camera and cropping view on Android 15 #2102

flipflop97 opened this issue Oct 15, 2024 · 7 comments

Comments

@flipflop97
Copy link

flipflop97 commented Oct 15, 2024

Version

Tell us which versions you are using:

  • react-native-image-crop-picker v0.41.4
  • react-native v0.75.4

Platform

Tell us to which platform this issue is related

  • iOS
  • Android

Expected behaviour

Camera picker should have device insets to make sure elements are not drawn underneath the system bars

Actual behaviour

Camera picker and cropper draw under system bars in some circumstances

Steps to reproduce

  1. Setup project which targets Android 15, and uses the camera image crop picker

  2. Run on Android virtual device "Pixel 8 Pro - API 35-ext13"

  3. Open the camera picker and cropper, and notice the system bars cover the top and bottom

Note that I cannot reproduce this on a real Pixel 8 Pro with Android 14 and edge-to-edge mode enabled but can reproduce on a real Pixel 8 Pro with Android 15

Attachments

image
@flipflop97
Copy link
Author

Update: Just tested this on my real Pixel 8 Pro with Android 15, and the issue also appears there

@flipflop97 flipflop97 changed the title Camera and cropping view on AVD 35-ext13 Camera and cropping view on Android 15 Oct 17, 2024
@SectionTN
Copy link

having the same issue

@mozzius
Copy link

mozzius commented Dec 20, 2024

@almastabssam
Copy link

@ivpusic @mozzius Please update library with above changes and create the PR. Thanks

@mozzius
Copy link

mozzius commented Jan 9, 2025

Here's the patch file I made for Bluesky: https://github.com/bluesky-social/social-app/blob/main/patches/react-native-image-crop-picker+0.41.6.patch

Feel free to make a PR, but it is a temporary solution. It would be better to handle the insets properly

@almastabssam
Copy link

almastabssam commented Jan 10, 2025 via email

@mozzius
Copy link

mozzius commented Jan 10, 2025

I'd love to but I am not a maintainer and I don't know Android dev :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants