Skip to content

Commit

Permalink
remove cfr, update gson, update junit
Browse files Browse the repository at this point in the history
  • Loading branch information
ix0rai committed Jul 17, 2024
1 parent 71fe7aa commit f1b314b
Show file tree
Hide file tree
Showing 7 changed files with 2 additions and 246 deletions.
12 changes: 0 additions & 12 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ dependencies {
javadocClasspath(libs.quilt.loader)
javadocClasspath(libs.jetbrains.annotations)
javadocClasspath(libs.jsr305) // for some other jsr annotations
decompileClasspath(libs.cfr)
unpick(libs.unpick.cli)
hashed "org.quiltmc:hashed:${minecraft_version}${USE_SNAPSHOT_HASHES ? "-SNAPSHOT" : ""}"
intermediary "net.fabricmc:intermediary:${minecraft_version}:v2"
Expand Down Expand Up @@ -283,17 +282,6 @@ task genFakeSource(type: DecompileTask, dependsOn: [mergeTinyV2, eraseBytecode])
}
}

task decompileCFR(type: DecompileTask, dependsOn: [mapNamedJar]) {
input.set mappings.fileConstants.namedJar
output.set file("namedSrc")
decompiler = Decompilers.CFR
libraries = files(configurations.decompileClasspath)

doFirst {
file("namedSrc").deleteDir()
}
}

task decompileVineflower(type: DecompileTask, dependsOn: [mapNamedJar]) {
input.set mappings.fileConstants.namedJar
output.set file("namedSrc")
Expand Down
1 change: 0 additions & 1 deletion buildSrc/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ dependencies {
implementation(libs.javadoc.draftsman)

// Decompilers
implementation(libs.cfr)
implementation(libs.vineflower)

// Testing
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
package quilt.internal.decompile;

import quilt.internal.decompile.cfr.CfrDecompiler;
import quilt.internal.decompile.vineflower.VineflowerDecompiler;

public enum Decompilers {
CFR(CfrDecompiler::new),
VINEFLOWER(VineflowerDecompiler::new);

private final DecompilerProvider provider;
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

6 changes: 2 additions & 4 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,12 @@ javadoc_draftsman = "1.2.3"
quilt_loader = "0.26.1"
jetbrains_annotations = "23.0.0"
jsr305 = "3.0.2"
gson = "2.9.1"
gson = "2.10.1"
netty = "4.1"

vineflower = "1.10.1"
cfr = "0.2.2"

junit = "5.9.1"
junit = "5.9.3"
proguard = "7.5.0"

[libraries]
Expand All @@ -48,7 +47,6 @@ jetbrains_annotations = { module = "org.jetbrains:annotations", version.ref = "j
jsr305 = { module = "com.google.code.findbugs:jsr305", version.ref = "jsr305" }

# Decompilers
cfr = { module = "net.fabricmc:cfr", version.ref = "cfr" }
vineflower = { module = "org.vineflower:vineflower", version.ref = "vineflower" }

# Testing
Expand Down

1 comment on commit f1b314b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With commit f1b314b, 1 file(s) were updated with 2 line(s) added and 2 removed compared to the latest Quilt Mappings version.

View the diff here:
Only in namedTargetSrc/net/minecraft/datafixer/fix: AttributeIdFix.java
Only in namedSrc/net/minecraft/datafixer/fix: AttributeModifierIdFix.java
diff -bur namedTargetSrc/net/minecraft/datafixer/Schemas.java namedSrc/net/minecraft/datafixer/Schemas.java
--- namedTargetSrc/net/minecraft/datafixer/Schemas.java	2024-07-17 00:48:11.058129267 +0000
+++ namedSrc/net/minecraft/datafixer/Schemas.java	2024-07-17 00:47:04.181489793 +0000
@@ -30,7 +30,7 @@
 import net.minecraft.datafixer.fix.AreaEffectCloudPotionFix;
 import net.minecraft.datafixer.fix.ArrowPickupFix;
 import net.minecraft.datafixer.fix.ArrowStoredWeaponFix;
-import net.minecraft.datafixer.fix.AttributeIdFix;
+import net.minecraft.datafixer.fix.AttributeModifierIdFix;
 import net.minecraft.datafixer.fix.BannerPatternFormatFix;
 import net.minecraft.datafixer.fix.BedBlockEntityFix;
 import net.minecraft.datafixer.fix.BedItemColorFix;
@@ -1373,7 +1373,7 @@
       Schema schema225 = builder.addSchema(3943, EMPTY_IDENTIFIER_NORMALIZE);
       builder.addFixer(new OptionsMenuBlurrinessFix(schema225));
       Schema schema226 = builder.addSchema(3945, EMPTY_IDENTIFIER_NORMALIZE);
-      builder.addFixer(new AttributeIdFix(schema226));
+      builder.addFixer(new AttributeModifierIdFix(schema226));
       builder.addFixer(new JukeboxTicksSinceSongStartedFix(schema226));
    }
 

Please sign in to comment.