Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable analysis of uploads #388

Open
zwimer opened this issue Jun 18, 2023 · 3 comments
Open

Add option to disable analysis of uploads #388

zwimer opened this issue Jun 18, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@zwimer
Copy link

zwimer commented Jun 18, 2023

The Problem

When uploading large files,
The dashboard plugin runs some analysis when uploading files, when these files are large this can be very slow. This entirely freezes/hangs octoprint for minutes on end. A log snippet is attached as an example:

octoprint  | 2023-06-18 17:32:23,576 - octoprint.plugins.dashboard - INFO - GcodePreProcessor started processing.
octoprint  | 2023-06-18 17:40:31,203 - octoprint.plugins.dashboard - INFO - GcodePreProcessor found layers: 993
octoprint  | 2023-06-18 17:40:31,230 - octoprint.plugins.dashboard - INFO - GcodePreProcessor found filament changes: 0
octoprint  | 2023-06-18 17:40:31,231 - octoprint.plugins.dashboard - INFO - GcodePreProcessor saving layer count in file metadata

Notice the 8 minute gap between the analysis starting and finishing. During this time, octoprint is otherwise frozen. This was for an 85 MB file on a raspberry pi 3b.

The Solution

Provide a way to disable analysis for files on upload.

Alternatives

I keep this plugin disabled sometimes, for uploads even larger than the 85 MB example above, this can hang octoprint for a very long time.

@zwimer zwimer added the enhancement New feature or request label Jun 18, 2023
@thijstriemstra
Copy link

Add option to disable

if it's the default, i'd call it a bug.

@j7126
Copy link
Owner

j7126 commented Jul 25, 2023

The analysis is required for many of the features of dashboard to work. I wouldn't call the fact that it runs a bug, however it shouldn't cause octoprint to freeze.

@zwimer If you send your entire log file I may be able to look into why it freezes octoprint.

I think the best idea in the mean time is to add an option to disable it for files over a given size.

@zwimer
Copy link
Author

zwimer commented Jul 30, 2023

I won't be able to for a bit, but when my setup is ready again I will post those logs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants