Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote display #38

Open
cvasanthk opened this issue Jan 6, 2025 · 10 comments · Fixed by #39
Open

Quote display #38

cvasanthk opened this issue Jan 6, 2025 · 10 comments · Fixed by #39
Labels
bug Something isn't working enhancement New feature or request

Comments

@cvasanthk
Copy link

cvasanthk commented Jan 6, 2025

This is the best Bible reference + Link verse plugin which I have found after testing many in the community plugin. Great job @jaanonim !!! God bless you!

environment: youversion-linker plugin Version 1.4.4.; MacOS 15.2; obsidian installer 1.7.7

I recently discovered regarding the "Quote trigger" which was the reason I was looking at other options. Now that it is available, I was experimenting with this feature.

Here is what I see when I use. I use , for verse trigger and > for Quote trigger.
I typed ,> John1.1-3 for quote/embedded view. I view the below quote appearance in both edit and reading view.
Quotetrigger

I see , >[!Quote] John 1:1-3 KJV from my view, this does not seem to be the right behaviour of the quote or callout block.

I would like to check if there a way to bring the quote view , more aesthetically pleasing in the note. In the standard Obsidian callout, the > triggers the callout as below:

[!tip] Callouts can have custom titles
Like this one.

image

The below is taken using Bible Reference plugin. I'm looking for something like this when I type ,> John1.1-3 for quote/embedded view.
I tried adjusting the space between > and [!Quote] in the output which is generated by the plugin , >[!Quote] John 1:1-3 KJV; but this does not work too.
this is my desired output, taken from Bible reference plugin:
Quotetrigger_request

  1. is there a CSS or some config which I miss to get the quote or callout block nicely
  2. Instead of !Quote, is it possible to change it to !bible and get the callout as appearing in " Bible reference Plugin?

thank you in advance!

@jaanonim jaanonim added bug Something isn't working enhancement New feature or request labels Jan 6, 2025
@jaanonim
Copy link
Owner

jaanonim commented Jan 6, 2025

That's a bug when typing > Mt 1:2 there shoudl be callout instereted like this:
image

@jaanonim jaanonim linked a pull request Jan 6, 2025 that will close this issue
@jaanonim
Copy link
Owner

jaanonim commented Jan 6, 2025

Bug fixed in #39

@cvasanthk
Copy link
Author

cvasanthk commented Jan 6, 2025

  1. The quote trigger does not work when selecting multiple verses. Example: > John1,1-3,8-9 whereas it works when triggered 'without the quote'. john 1:3, 8-9. Any views on how to make this work with the quote trigger?
  2. Instead of the quote symbol , can there be a customizing option to use a [!Bible]
    @jaanonim

@jaanonim jaanonim reopened this Jan 6, 2025
@jaanonim
Copy link
Owner

jaanonim commented Jan 6, 2025

  1. I have implemented that future in add custom callouts #40 - there will be settings filed for callout name. So you can select build in one or define one yourself using css snipets like:
.callout[data-callout='bible'] {
	--callout-color: #776677;
	--callout-icon: "<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 448 512'>...</svg>";
}

And plugin now will ship with Bible callout with icon same as obsidian-bible-reference

@jaanonim
Copy link
Owner

jaanonim commented Jan 6, 2025

  1. I cannot repicate that issue. Please update to version 1.5.0 and then check if issue still presists and then let me know. If it still presists maybe look into console if there are any errors there.
    @cvasanthk

@cvasanthk
Copy link
Author

cvasanthk commented Jan 6, 2025

  1. I cannot repicate that issue. Please update to version 1.5.0 and then check if issue still presists and then let me know. If it still presists maybe look into console if there are any errors there.
    @cvasanthk

Thanks for the quick turnaround for the callout. I have installed 1.5 and it works very well.

Here is the answer to your query:

Plugin Settings:
image

Now, I typed just with link trigger with comma as below and it works fine with the link trigger.
image
Here I get the output as designed. john 1:1-3, 8-9

When I use the quote trigger > for the same, with , >John1.1-3,8-9 , I see the link appearing as below.
image

However the output appears with the comma and the quote below:
image

@jaanonim

@cvasanthk
Copy link
Author

  1. I have implemented that future in add custom callouts #40 - there will be settings filed for callout name. So you can select build in one or define one yourself using css snipets like:
.callout[data-callout='bible'] {
	--callout-color: #776677;
	--callout-icon: "<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 448 512'>...</svg>";
}

And plugin now will ship with Bible callout with icon same as obsidian-bible-reference

@jaanonim - Super quick implementation. This works awesome , thanks a lot!!!

@jaanonim
Copy link
Owner

jaanonim commented Jan 6, 2025

@cvasanthk
Link and quote trigers are sepret things:
so if you want link you type just (with your config): ,J 1:1
and to make quote you just type >J 1:1 (no need for comma there)
The comma you type there plugin see as any other text so it leaves it as it is.

@jaanonim jaanonim closed this as completed Jan 6, 2025
@cvasanthk
Copy link
Author

cvasanthk commented Jan 7, 2025

@jaanonim
image

I was referring to multiple verses linked using Quote trigger:
`>john1.1-3,8-9

does not yield any results once I put comma after 3 to link verses 8-9. But it works when I put the comma and > as below:
`, >John1.1-3,8-9

@jaanonim
Copy link
Owner

jaanonim commented Jan 7, 2025

@jaanonim image

I was referring to multiple verses linked using Quote trigger: `>john1.1-3,8-9

does not yield any results once I put comma after 3 to link verses 8-9. But it works when I put the comma and > as below: `, >John1.1-3,8-9

I cannot repicate that :(
It works fine on my site:
image

You can try doing thoes steps:

  1. Try to disable others community plugins - they may mess up suggestions
  2. Open dev console in obsydian and check if there are any errors

@jaanonim jaanonim reopened this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants