Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Graphicle.final to be computed from edge info if missing from ParticleSet #174

Open
jacanchaplais opened this issue Mar 1, 2024 · 1 comment
Open

Enable Graphicle.final to be computed from edge info if missing from ParticleSet #174

jacanchaplais opened this issue Mar 1, 2024 · 1 comment
Assignees
@jacanchaplais
Labels
enhancement New feature or request

Comments

@jacanchaplais
Copy link
Owner

In the case that a Graphicle object has a ParticleSet without a final mask, compute it from the adjacency.
@jacanchaplais jacanchaplais added the enhancement New feature or request label Mar 1, 2024
@jacanchaplais jacanchaplais self-assigned this Mar 1, 2024
jacanchaplais added a commit that referenced this issue Mar 1, 2024
@jacanchaplais
fall back to adj.leaves if particles.final missing #174
6402157
jacanchaplais added a commit that referenced this issue Mar 1, 2024
@jacanchaplais
cached computed Graphicle.final #174
1871a6a
jacanchaplais added a commit that referenced this issue Mar 1, 2024
@jacanchaplais
attrs update for cache with slots #174
f001db1
jacanchaplais added a commit that referenced this issue Mar 1, 2024
@jacanchaplais
added test for Graphicle subscripting #174
f7d0b4e
jacanchaplais added a commit that referenced this issue Mar 1, 2024
@jacanchaplais
added data file for prev commit added test #174
924ce69
@jacanchaplais
Copy link
Owner Author

Added failing test for subscripting Graphicle objects. This has broken, because the cached_property of Graphicle.final is now showing up as an attrs field, or something, and getting passed to the Graphicle constructor method. Needs fixing before merging.

@github-project-automation github-project-automation bot moved this to To do in graphicle Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacanchaplais jacanchaplais

Labels
enhancement New feature or request
Projects
graphicle
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacanchaplais