-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configuration consistency with other jaeger components #85
Comments
I'm all for naming consistency, especially if they follow the same syntax (comma-separated URL values, |
Hello @pavolloffay @yurishkuro @jpkrohling
Requirement - what kind of business use case are you trying to solve?
Trying to reuse config across various jaeger components. Works quite well except for schema, spark-job and es-index-cleaner components. This issue is to address the inconsistencies with spark. A separate issue was opened to address es index cleaner but "closed as wont-fix": jaegertracing/jaeger#2124.
Problem - what in Jaeger blocks you from solving the requirement?
example:
spark-job -> ES_NODES, CASSANDRA_CONTACT_POINTS
other components -> ES_SERVER_URLS, CASSANDRA_SERVERS
Proposal - what do you suggest to solve the problem or improve the existing situation?
Keep environment variable names consistent with main components (collector, query, ingester)
The text was updated successfully, but these errors were encountered: