-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to override default parameters #43
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm testing out
@minimal-analytics/ga4
on KaiOS apps but I'm running into an issue with because package apps are served with an origin likeapp://myapp.com/
. The document location includes theapp:
protocol, and Google Analytics appears to discard the page path (but not page title) as a result. In Universal Analytics, I replaced theapp:
protocol withhttps:
and it worked well.Looking at
getQueryParams
, the event parameters are concatenated with the default parameters. If I pass{ dl: 'https://myapp.com/index.html' }
, it sends twodl
parameters because of the behavior ofURLSearchParams
.Would you consider changing the behavior to allow overriding default parameter values? This should be a non-breaking change, since anyone attempting to override default parameters now would have a bad request anyway.
The text was updated successfully, but these errors were encountered: