-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two initial bugs: something with missing "author" and mistakes from CrossRef #1
Comments
BTW, thanks for this tool!! |
Hi! Thanks for the feedback! I have added two commits addressing (or trying to) these issues.
Let me know if this helps. This is not a definitive solution by any means, so please keep reporting issues! |
@jaimergp Thanks for working in those fixes! I'm amazed at how many fixes your codes suggests. A few remaining issues I run into (you may want to re-download https://github.com/dmzuckerman/Sampling-Uncertainty/blob/master/refs.bib):
Again, many, many thanks! |
Hi again @dwsideriusNIST! Please, check the new changes! I have (hopefully) addressed both points. Regarding dates: Crossref provides both online and print publication dates. Until now we were choosing the online one for all cases, but now the script will use the print date if available, and the online one as a fallback. |
Hello, I'm associated with @davidmobley who started the twitter question that led to your fixbibtex project.
I've tested your code and found some opportunities for improvements. First, use this BibTeX file to reproduce my issues:
https://github.com/dmzuckerman/Sampling-Uncertainty/blob/e98db8be56fb89bf0b7261bbb20d6f5b3945dff6/refs.bib
The first bug is that some BibTeX entries cause the script to crash if the "author" key is empty. The problematic key for the "refs.bib" example is "NIST_SRSW"
The script is making some erroneous substitutions. E.g., "Kabsch1976" and "Leimkuhler" are replaced by the wrong article or book.
I suspect that the problem is that CrossRef's search is returning the wrong reference. Maybe incorporate some basic error checking to avoid really erroneous substitutions?
The text was updated successfully, but these errors were encountered: