Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential blind spot? #4

Closed
isabelroses opened this issue Apr 22, 2024 · 2 comments
Closed

Potential blind spot? #4

isabelroses opened this issue Apr 22, 2024 · 2 comments

Comments

@isabelroses
Copy link

I'm not sure if the missing PR was intentionally left out or there is a blindspot with your github PR fetching script.

Mentioned PRs

  • 2024-04-21 - 303817 - adds fork-cleaner
  • 2024-04-14 - 303997 - adds pace

Missing PRs

@jakehamilton
Copy link
Owner

Hmm yeah that seems like it should have been included. If the PR was merged between Sunday and Saturday of last week then the script should have fetched it. I have had issues with the GitHub API, I wonder if there is something strange going on or if my logic is incomplete...

I'll add a mention for the package, thank you!

@jakehamilton
Copy link
Owner

I've updated the latest issue to include kittysay (thanks again); I'm going to close this issue for now, but I'm fairly convinced that my script isn't fetching all of the merged PRs from the previous week. If this happens again then maybe I can try looking into it, otherwise it's possible that this is a fluke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants