-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nicer way to add new languages #30
Labels
enhancement
New feature or request
Comments
This is a good idea! Do you want to make a PR or should I do this? |
I'm writing the Spanish support, I could add the modification in that PR |
That would be good, thank you Andrés. Would it still be a keyword argument? I.e., would I be able to write spelled_out(123467, lang = :ru) ? And would we still be able to have aliases and equivalences? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in master, the list of languages supported is hardcoded. what if we dispatch on
Val{:sym}
? something like:and each impl. could just simply do:
the use of the type instead of building the val is because there is a cost on building the struct, that is elided completely when only using the type
as a nice consequence of using this, an external user could plug its own spelling function, or modify the output of existing ones
The text was updated successfully, but these errors were encountered: